Fix 16 tests failures on devtools/client/inspector/computed due the EventEmitter refactoring

NEW
Unassigned

Status

()

Firefox
Developer Tools: Computed Styles Inspector
P2
normal
6 months ago
2 months ago

People

(Reporter: zer0, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fix-optional)

Details

(Reporter)

Description

6 months ago
Failing tests:

devtools/client/inspector/computed/test/browser_computed_browser-styles.js
devtools/client/inspector/computed/test/browser_computed_cycle_color.js
devtools/client/inspector/computed/test/browser_computed_getNodeInfo.js
devtools/client/inspector/computed/test/browser_computed_keybindings_01.js
devtools/client/inspector/computed/test/browser_computed_keybindings_02.js
devtools/client/inspector/computed/test/browser_computed_matched-selectors-toggle.js
devtools/client/inspector/computed/test/browser_computed_matched-selectors_01.js
devtools/client/inspector/computed/test/browser_computed_matched-selectors_02.js
devtools/client/inspector/computed/test/browser_computed_media-queries.js
devtools/client/inspector/computed/test/browser_computed_no-results-placeholder.js
devtools/client/inspector/computed/test/browser_computed_original-source-link.js
devtools/client/inspector/computed/test/browser_computed_pseudo-element_01.js
devtools/client/inspector/computed/test/browser_computed_refresh-on-style-change_01.js
devtools/client/inspector/computed/test/browser_computed_search-filter.js
devtools/client/inspector/computed/test/browser_computed_select-and-copy-styles-01.js
devtools/client/inspector/computed/test/browser_computed_select-and-copy-styles-02.js


The refactoring is currently only on:

https://github.com/zer0/gecko/tree/event-emitter-1381542

We need to address the test failures before land this patch in m-c.
(Reporter)

Comment 1

6 months ago
Here the original try build with the failures:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bba13e27a2371fa8aad68b9b227534b31829cb0d

Those failures are most likely due the breaking change in how the `EventEmitter` emits event.

Previously, the first argument was the event type:

  myEmitter.on("custom-event", (eventType, message) => { ... });

Now the first argument is the message:

  myEmitter.on("custom-event", (message) => { ... });

In the majority of the scenario the `eventType` is ignored by our code, so we should just remove it from the function's signature.

For more details and edge cases, see: https://github.com/devtools-html/snippets-for-removing-the-sdk/#events

Updated

6 months ago
Flags: qe-verify-
Priority: -- → P2
(Reporter)

Updated

6 months ago
No longer blocks: 1381542
(Reporter)

Updated

6 months ago
Blocks: 1384546
(Reporter)

Updated

6 months ago
Whiteboard: [nosdk]

Updated

4 months ago
status-firefox57: --- → fix-optional
No longer blocks: 1402832

Updated

2 months ago
Component: Developer Tools → Developer Tools: Computed Styles Inspector
You need to log in before you can comment on or make changes to this bug.