[python-fluent] Standalone comments don't serialize OK

RESOLVED FIXED

Status

L20n
Python Library
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: Pike, Unassigned)

Tracking

Details

(Reporter)

Description

10 months ago
For an FTL file like so:


foo = Foo

// some comment

bar = Bar


the serializer creates

// some commentbar = Bar


That seems to be one driver of the problems that pontoon has in syncing the screenshots server.ftl, bug 1382538.
Thanks for reporting!

Fixed in https://github.com/projectfluent/python-fluent/commit/12bd77a3446d837fa360c4cfef45981066d69942
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
(Reporter)

Comment 2

10 months ago
Sorry, but I think this needs to come with tests to be marked FIXED.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Yeah, thanks for bringing it up.

I'm not sure about if I like how we test serializer now and was originally planning to talk to stas about it before landing additional tests.

But that's stupid. I landed a test now: https://github.com/projectfluent/python-fluent/commit/a9621696edbaa7209c22066f7c12aad11f1c5e70 :)
Status: REOPENED → RESOLVED
Last Resolved: 10 months ago10 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.