Closed
Bug 1382632
Opened 7 years ago
Closed 7 years ago
[c-c] Make installers-% "just work", hard-code build internals or provide sane defaults
Categories
(Thunderbird :: Build Config, enhancement)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: Pike)
References
Details
User Story
./mozilla/mach installers-de should just work. Hide l10n-merge, and hard-code the directory in which we do that in the build system. Check out locales from l10n-central if needed. L10NBASEDIR should have a sound default, ~/.mozbuild/l10n-central. The automatic check-out of l10n-repos is for Nightly only, to not affect beta builds, which require dedicated revisions. Also, I don't bother to update the l10n repos. wget-en-US' EN_US_BINARYURL should have a sane default. Which I found for desktop. Not sure if there's one for mobile, and if I can deduce that from config.status. Create a reliable make variable for when you're in an l10n repack task, and when you're not, and make that independent of configure. Also, have one for langpacks explicitly. Workflows: For developers: ./mozilla/mach package ./mozilla/mach build installers-de For repacks: ./mozilla/mach wget-en-US ./mozilla/mach build installers-de
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1370506 +++ This is the follow-up fixes we need in comm-central for bug 1370506, on the Thunderbird side. We'll need similar fixes from the SeaMonkey folks, too. Doing the Thunderbird part to demonstrate that it can happen.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8888275 [details] bug 1382632, make installers-% just work, tb follow-up, https://reviewboard.mozilla.org/r/159218/#review169886 I can succesfully build packages, and repack L10N builds locally with this.
Attachment #8888275 -
Flags: review?(mozilla) → review+
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/comm-central/rev/72451623db7f make installers-% just work, tb follow-up; r=tomprince
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Backout by mozilla@hocat.ca: https://hg.mozilla.org/comm-central/rev/0f6ba3764821 Backed out changeset 72451623db7f for causing build upload failures; a=backout DONTBUILD
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8888275 [details] bug 1382632, make installers-% just work, tb follow-up, https://reviewboard.mozilla.org/r/159218/#review169932 https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=72451623db7f2bcc4794cf146ac48515fdb2c494 ::: calendar/lightning/lightning-packager.mk:165 (Diff revision 2) > > # Lightning uses Thunderbird's build machinery, so we need to hack the post > # upload command to use Lightning's directories and version. > upload: upload-$(AB_CD) > + > +upload-%: AB_CD=$* It looks like setting this isn't inherited by `stage_upload` which causes that step to fail. I think `stage_upload` is an internal target, so it could be made a per-AB_CD pattern; in which case it appears (?!) to inheirt the setting of `AB_CD`.
Attachment #8888275 -
Flags: review+ → review-
Comment 7•7 years ago
|
||
Something like https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9aacf880a693213cbedb1963f2b2450b494b4f1b might fix things.
Flags: needinfo?(l10n)
Assignee | ||
Comment 8•7 years ago
|
||
I'd guess not, but maybe if you add a AB_CD=$* to https://hg.mozilla.org/try-comm-central/rev/9aacf880a693213cbedb1963f2b2450b494b4f1b#l1.20
Flags: needinfo?(l10n)
Assignee | ||
Comment 9•7 years ago
|
||
Reopening, as this has been backed out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 10•7 years ago
|
||
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/comm-central/rev/50956da0582f make installers-% just work, tb follow-up; r=tomprince DONTBUILD
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•