Closed
Bug 1382646
Opened 7 years ago
Closed 4 years ago
"Report site issue" available for "about:" pages restored from "Recently closed"
Categories
(Firefox for Android Graveyard :: General, defect, P5)
Tracking
(fennec+, firefox56 affected)
RESOLVED
WONTFIX
People
(Reporter: sflorean, Assigned: miketaylr)
References
Details
Attachments
(2 files)
Environment: Device: HTC 10 (Android 7.0), Honor 8 (Android 6.0); Build: Nightly 56.0a1 (2017-07-20); Steps to reproduce: 1. Launch Fennec and open about:config, about:firefox, cnn.com, about:accounts in different tabs; 2. Close Fennec from task manager; 3. Launch Fennec and go to History panel -> Recently closed and restore all tabs; 4. Go to any page "about:.." and tap on three dots menu. Expected result: For pages with "about:.." the option "Report site issue" is not available. Actual result: For pages with "about:.." the option "Report site issue" is available.
Updated•7 years ago
|
tracking-fennec: ? → +
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → miket
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8966411 [details] Bug 1382646. Use scheme allowlist for isReportableUrl. https://reviewboard.mozilla.org/r/235110/#review241176 A whitelist makes more sense than a blacklist so this wfm if it works for you. Mike, why did the old implementation cause issues though? Was session restore removing the `about:` scheme?
Attachment #8966411 -
Flags: review?(michael.l.comella) → review+
Flags: needinfo?(sorina.florean)
Flags: needinfo?(miket)
Flags: needinfo?(sorina.florean)
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Michael Comella (:mcomella) [needinfo or I won't see it] from comment #2) > Mike, why did the old implementation cause issues though? Was session > restore removing the `about:` scheme? That's what I assumed... I wrote this first patch just to "clean up" and start investigating... but can't repro with this patch anymore. Sorina, just so we're actually fixing this (and so I understand the fix), can you explain what task manager you're using to kill Fennec with?
Flags: needinfo?(miket) → needinfo?(sorina.florean)
Reporter | ||
Comment 4•6 years ago
|
||
(In reply to Mike Taylor [:miketaylr] from comment #3) > (In reply to Michael Comella (:mcomella) [needinfo or I won't see it] from > comment #2) > > Mike, why did the old implementation cause issues though? Was session > > restore removing the `about:` scheme? > > That's what I assumed... I wrote this first patch just to "clean up" and > start investigating... but can't repro with this patch anymore. Sorina, just > so we're actually fixing this (and so I understand the fix), can you explain > what task manager you're using to kill Fennec with? From recent apps list, I swipe to kill the app.
Flags: needinfo?(sorina.florean)
Comment 6•6 years ago
|
||
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195 Needinfo :susheel if you think this bug should be re-triaged.
Priority: P3 → P5
Assignee | ||
Updated•4 years ago
|
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•