"Report site issue" available for "about:" pages restored from "Recently closed"

NEW
Assigned to

Status

()

Firefox for Android
General
P3
normal
10 months ago
a month ago

People

(Reporter: sorina, Assigned: miketaylr)

Tracking

56 Branch
ARM
Android
Points:
---

Firefox Tracking Flags

(fennec+, firefox56 affected)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

10 months ago
Created attachment 8888284 [details]
2017_07_20_16_05_10_Screenshot_2017_07_20_14_23_21.png_Photos.png

Environment: 
Device: HTC 10 (Android 7.0), Honor 8 (Android 6.0);
Build: Nightly 56.0a1 (2017-07-20);

Steps to reproduce:
1. Launch Fennec and open about:config, about:firefox, cnn.com, about:accounts in different tabs;
2. Close Fennec from task manager;
3. Launch Fennec and go to History panel -> Recently closed and restore all tabs;
4. Go to any page "about:.." and tap on three dots menu.

Expected result:
For pages with "about:.." the option "Report site issue" is not available.

Actual result:
For pages with "about:.." the option "Report site issue" is available.

Updated

10 months ago
tracking-fennec: ? → +
Priority: -- → P3
Assignee: nobody → miket
Comment hidden (mozreview-request)
Comment on attachment 8966411 [details]
Bug 1382646. Use scheme allowlist for isReportableUrl.

https://reviewboard.mozilla.org/r/235110/#review241176

A whitelist makes more sense than a blacklist so this wfm if it works for you.

Mike, why did the old implementation cause issues though? Was session restore removing the `about:` scheme?
Attachment #8966411 - Flags: review?(michael.l.comella) → review+
Flags: needinfo?(sorina.florean)
Flags: needinfo?(miket)
Flags: needinfo?(sorina.florean)
(In reply to Michael Comella (:mcomella) [needinfo or I won't see it] from comment #2)
> Mike, why did the old implementation cause issues though? Was session
> restore removing the `about:` scheme?

That's what I assumed... I wrote this first patch just to "clean up" and start investigating... but can't repro with this patch anymore. Sorina, just so we're actually fixing this (and so I understand the fix), can you explain what task manager you're using to kill Fennec with?
Flags: needinfo?(miket) → needinfo?(sorina.florean)
(Reporter)

Comment 4

2 months ago
(In reply to Mike Taylor [:miketaylr] from comment #3)
> (In reply to Michael Comella (:mcomella) [needinfo or I won't see it] from
> comment #2)
> > Mike, why did the old implementation cause issues though? Was session
> > restore removing the `about:` scheme?
> 
> That's what I assumed... I wrote this first patch just to "clean up" and
> start investigating... but can't repro with this patch anymore. Sorina, just
> so we're actually fixing this (and so I understand the fix), can you explain
> what task manager you're using to kill Fennec with?

From recent apps list, I swipe to kill the app.
Flags: needinfo?(sorina.florean)
Duplicate of this bug: 1427055
You need to log in before you can comment on or make changes to this bug.