1382647 - Improve performance of searching for globals with the various global rules of ESLint

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Mark Banner (:standard8)]

I was planning on fixing globals importing when we're using things like forEach on arrays (bug 1325373), however prior to that I got into looking at the performance of the existing code and seeing if we can improve it.

By a little bit of refining what we're looking for we can generally avoid having to rebuild the source and matching it. This shaves off about 10 seconds from a 2m30 run on my machine.

Whilst it isn't much relatively speaking, it will help builders & potentially others - I still think it is worth doing. Seeing as I will be afk for a bit soon, I though we might as well get it landed now.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1382647 - Improve eslint-plugin-mozilla's performance when searching for globals by avoiding rebuilding source when we don't need to.

Review commit: https://reviewboard.mozilla.org/r/159242/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159242/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8888288 [details]
Bug 1382647 - Improve eslint-plugin-mozilla's performance when searching for globals by avoiding rebuilding source when we don't need to.

https://reviewboard.mozilla.org/r/159242/#review164850

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfeea9fdf02f
Improve eslint-plugin-mozilla's performance when searching for globals by avoiding rebuilding source when we don't need to. r=mossop

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bfeea9fdf02f