Label dispatches from imgRequestProxy::Cancel

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aosmond, Assigned: aosmond)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
imgRequestProxy::Cancel and imgRequestProxy::CancelAndForgetObserver call NS_DispatchToCurrentThread. These need to switch to our labelled event target (if available).
(Assignee)

Updated

2 years ago
Assignee: nobody → aosmond
Blocks: 1350938
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [gfx-noted]
(Assignee)

Updated

2 years ago
Attachment #8888317 - Flags: review?(tnikkel)
Comment on attachment 8888317 [details] [diff] [review]
imgRequestProxy::DoRemoveFromLoadGroup and imgCancelRunnable should be dispatched on labelled group if possible., v1

The name of the new function is kinda confusing, but I don't have a better idea.
Attachment #8888317 - Flags: review?(tnikkel) → review+
(Assignee)

Comment 3

2 years ago
I renamed Dispatch to DispatchWithTarget (will assert it has a target) and DispatchExpected to DispatchWithTargetIfAvailable (will use it if available, else use unlabelled).
Attachment #8888317 - Attachment is obsolete: true
Attachment #8897385 - Flags: review+

Comment 4

2 years ago
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89f97a79f232
imgRequestProxy::DoRemoveFromLoadGroup and imgCancelRunnable should be dispatched on labelled group if possible. r=tnikkel

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/89f97a79f232
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.