1382661 - Stop adding "DeveloperToolbar" to top level window object

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

a DeveloperToolbar attribute is being set on all browser.xul window object.
It appears to be an issue as these are reported as leaks during mochitest if we load devtools more lazily, like in bug 1359855.

Instead we should retrieve this "per window singleton" via some API on some devtools module.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1382661 - Stop injecting DeveloperToolbar on top level windows.

Review commit: https://reviewboard.mozilla.org/r/159254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159254/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8888302 [details]
Bug 1382661 - Stop injecting DeveloperToolbar on top level windows.

https://reviewboard.mozilla.org/r/159254/#review164888

Looks good, r+ with a green try

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8888302 [details]
Bug 1382661 - Stop injecting DeveloperToolbar on top level windows.

https://reviewboard.mozilla.org/r/159254/#review165036

::: devtools/client/shared/test/browser_toolbar_webconsole_errors_count.js:32
(Diff revision 1)
>    });
>  
>    ignoreAllUncaughtExceptions();
>    addTab(TEST_URI).then(openToolbar);
>  
> +  let toolbar = gDevToolsBrowser.getDeveloperToolbar(window);

Looks like this test is failing locally and on try.

> 21 INFO TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_toolbar_webconsole_errors_count.js | 
> This test contains no passes, no fails and no todos. Maybe it threw a silent exception? 
> Make sure you use waitForExplicitFinish() if you need it. -

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8888302 [details]
Bug 1382661 - Stop injecting DeveloperToolbar on top level windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159254/diff/1-2/

Comment 5

[Alexandre Poirot [:ochameau]]

Test fixed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c811f18f417a

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac0b38e56614
Stop injecting DeveloperToolbar on top level windows. r=jdescottes

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ac0b38e56614