Closed Bug 1382661 Opened 4 years ago Closed 4 years ago
Stop adding "Developer
Toolbar" to top level window object
59 bytes, text/x-review-board-request
a DeveloperToolbar attribute is being set on all browser.xul window object. It appears to be an issue as these are reported as leaks during mochitest if we load devtools more lazily, like in bug 1359855. Instead we should retrieve this "per window singleton" via some API on some devtools module.
Comment on attachment 8888302 [details] Bug 1382661 - Stop injecting DeveloperToolbar on top level windows. https://reviewboard.mozilla.org/r/159254/#review164888 Looks good, r+ with a green try
Attachment #8888302 - Flags: review?(jdescottes) → review+
Comment on attachment 8888302 [details] Bug 1382661 - Stop injecting DeveloperToolbar on top level windows. https://reviewboard.mozilla.org/r/159254/#review165036 ::: devtools/client/shared/test/browser_toolbar_webconsole_errors_count.js:32 (Diff revision 1) > }); > > ignoreAllUncaughtExceptions(); > addTab(TEST_URI).then(openToolbar); > > + let toolbar = gDevToolsBrowser.getDeveloperToolbar(window); Looks like this test is failing locally and on try. > 21 INFO TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_toolbar_webconsole_errors_count.js | > This test contains no passes, no fails and no todos. Maybe it threw a silent exception? > Make sure you use waitForExplicitFinish() if you need it. -
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ac0b38e56614 Stop injecting DeveloperToolbar on top level windows. r=jdescottes
You need to log in before you can comment on or make changes to this bug.