Stop adding "DeveloperToolbar" to top level window object

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Developer Tools: Graphic Commandline and Toolbar
P3
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
a DeveloperToolbar attribute is being set on all browser.xul window object.
It appears to be an issue as these are reported as leaks during mochitest if we load devtools more lazily, like in bug 1359855.

Instead we should retrieve this "per window singleton" via some API on some devtools module.
Comment hidden (mozreview-request)
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Priority: -- → P3

Comment 2

5 months ago
mozreview-review
Comment on attachment 8888302 [details]
Bug 1382661 - Stop injecting DeveloperToolbar on top level windows.

https://reviewboard.mozilla.org/r/159254/#review164888

Looks good, r+ with a green try
Attachment #8888302 - Flags: review?(jdescottes) → review+

Comment 3

5 months ago
mozreview-review
Comment on attachment 8888302 [details]
Bug 1382661 - Stop injecting DeveloperToolbar on top level windows.

https://reviewboard.mozilla.org/r/159254/#review165036

::: devtools/client/shared/test/browser_toolbar_webconsole_errors_count.js:32
(Diff revision 1)
>    });
>  
>    ignoreAllUncaughtExceptions();
>    addTab(TEST_URI).then(openToolbar);
>  
> +  let toolbar = gDevToolsBrowser.getDeveloperToolbar(window);

Looks like this test is failing locally and on try.

> 21 INFO TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_toolbar_webconsole_errors_count.js | 
> This test contains no passes, no fails and no todos. Maybe it threw a silent exception? 
> Make sure you use waitForExplicitFinish() if you need it. -
Comment hidden (mozreview-request)
(Assignee)

Comment 5

5 months ago
Test fixed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c811f18f417a

Comment 6

5 months ago
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac0b38e56614
Stop injecting DeveloperToolbar on top level windows. r=jdescottes

Comment 7

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ac0b38e56614
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.