1382664 - Label dispatch from RasterImage::OnSurfaceDiscarded

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

RasterImage::OnSurfaceDiscarded dispatches an unlabelled event to call RasterImage::OnSurfaceDiscardedInternal.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: RasterImage::OnSurfaceDiscarded should dispatch with ProgressTracker::GetEventTarget., v1

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ba3e35e178aafc8bc4eba9a52c8a31a4e66e91a

Comment 2

[Timothy Nikkel (:tnikkel)]

I thought we determined that this could be in the system group in another bug?

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Timothy Nikkel (:tnikkel) from comment #2)
> I thought we determined that this could be in the system group in another
> bug?

If there are no observers it will use the system group. But it does trigger imgINotificationObserver::DISCARD events to the observers, so I think we want to match the dispatch here as much as possible? It shouldn't be more harmful than the system group at least.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2807cf0b6271
RasterImage::OnSurfaceDiscarded should dispatch with ProgressTracker::GetEventTarget. r=tnikkel

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2807cf0b6271