1382667 - Implement an onBeforeCommand function for CustomizableUI that will run before the command is executed

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Some commands may want to change the appearance of their toolbarbutton before the associated command is executed or view is opened.

With the onBeforeCommand function, the widget will be able to adapt its UI before attributes are set on the button ([open="true"] is set on [type="view"] widgets for example).

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1382667 - Implement an onBeforeCommand function for CustomizableUI that will run before the command is executed.

Review commit: https://reviewboard.mozilla.org/r/159258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159258/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8888303 [details]
Bug 1382667 - Implement an onBeforeCommand function for CustomizableUI that will run before the command is executed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159258/diff/1-2/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8888303 [details]
Bug 1382667 - Implement an onBeforeCommand function for CustomizableUI that will run before the command is executed.

https://reviewboard.mozilla.org/r/159258/#review164924

::: browser/components/customizableui/CustomizableUI.jsm:3302
(Diff revision 2)
>     *                  passing the document from which it was removed. This is
>     *                  useful especially for 'view' type widgets that need to
>     *                  cleanup after views that were constructed on the fly.
> +   * - onBeforeCommand(aEvt): A function that will be invoked when the user
> +   *                          activates the button but before the command
> +   *                          is evaluating. Useful if code needs to run to

Nit: evaluated.

Might also be useful to clarify this also applies for view widgets that show a subview.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8888303 [details]
Bug 1382667 - Implement an onBeforeCommand function for CustomizableUI that will run before the command is executed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159258/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/687efdbdcd84
Implement an onBeforeCommand function for CustomizableUI that will run before the command is executed. r=Gijs

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/687efdbdcd84