1382672 - stylo: panicked at 'assertion failed: system == context.cached_system_font.as_ref().unwrap().system_font'

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Jesse Schwartzentruber (:truber)]

Attachment: testcase.html

The attached testcase causes a panic in m-c rev 68046a58f829 with stylo pref enabled.

thread '<unnamed>' panicked at 'assertion failed: system == context.cached_system_font.as_ref().unwrap().system_font', /home/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/build/style-a3e69c1fe576a835
/out/properties.rs:28807
stack backtrace:
   0: std::sys::imp::backtrace::tracing::imp::unwind_backtrace
   1: std::sys_common::backtrace::_print
   2: std::panicking::default_hook::{{closure}}
   3: std::panicking::default_hook
   4: std::panicking::rust_panic_with_hook
   5: std::panicking::begin_panic
   6: style::properties::longhands::system_font::resolve_system_font
   7: style::properties::animated_properties::AnimationValue::from_declaration
   8: <style::properties::declaration_block::AnimationValueIterator<'a, 'cx, 'cx_a> as core::iter::iterator::Iterator>::next
   9: Servo_GetComputedKeyframeValues
  10: mozilla::ServoStyleSet::GetComputedKeyframeValuesFor(nsTArray<mozilla::Keyframe> const&, mozilla::dom::Element*, mozilla::ServoStyleContext const*)
  11: nsTArray<mozilla::AnimationProperty> mozilla::KeyframeUtils::GetAnimationPropertiesFromKeyframes<mozilla::ServoStyleContext const>(nsTArray<mozilla::Keyframe> const&, mozilla::dom::Element*, mozilla::ServoStyleContext const*, mozilla
::dom::CompositeOperation)
  12: nsTArray<mozilla::AnimationProperty> mozilla::dom::KeyframeEffectReadOnly::BuildProperties<mozilla::ServoStyleContext const>(mozilla::ServoStyleContext const*)
  13: void mozilla::dom::KeyframeEffectReadOnly::DoUpdateProperties<mozilla::ServoStyleContext const>(mozilla::ServoStyleContext const*)
  14: void mozilla::dom::KeyframeEffectReadOnly::DoSetKeyframes<mozilla::ServoStyleContext const>(nsTArray<mozilla::Keyframe>&&, mozilla::ServoStyleContext const*)
  15: mozilla::dom::KeyframeEffectReadOnly::SetKeyframes(JSContext*, JS::Handle<JSObject*>, mozilla::ErrorResult&)
  16: already_AddRefed<mozilla::dom::KeyframeEffect> mozilla::dom::KeyframeEffectReadOnly::ConstructKeyframeEffect<mozilla::dom::KeyframeEffect, mozilla::dom::UnrestrictedDoubleOrKeyframeAnimationOptions>(mozilla::dom::GlobalObject const&,
 mozilla::dom::Nullable<mozilla::dom::ElementOrCSSPseudoElement> const&, JS::Handle<JSObject*>, mozilla::dom::UnrestrictedDoubleOrKeyframeAnimationOptions const&, mozilla::ErrorResult&)
  17: mozilla::dom::KeyframeEffect::Constructor(mozilla::dom::GlobalObject const&, mozilla::dom::Nullable<mozilla::dom::ElementOrCSSPseudoElement> const&, JS::Handle<JSObject*>, mozilla::dom::UnrestrictedDoubleOrKeyframeAnimationOptions co
nst&, mozilla::ErrorResult&)
  18: mozilla::dom::Element::Animate(mozilla::dom::Nullable<mozilla::dom::ElementOrCSSPseudoElement> const&, JSContext*, JS::Handle<JSObject*>, mozilla::dom::UnrestrictedDoubleOrKeyframeAnimationOptions const&, mozilla::ErrorResult&)
  19: mozilla::dom::Element::Animate(JSContext*, JS::Handle<JSObject*>, mozilla::dom::UnrestrictedDoubleOrKeyframeAnimationOptions const&, mozilla::ErrorResult&)
  20: mozilla::dom::ElementBinding::animate(JSContext*, JS::Handle<JSObject*>, mozilla::dom::Element*, JSJitMethodCallArgs const&)

Comment 1

[Jesse Schwartzentruber (:truber)]

Attachment: log.txt

Comment 2

[Manish Goregaokar [:manishearth]]

Ah, looks like when discrete animation was added the assert wasn't updated. It should just be removed.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

my fault..

Comment 4

[Manish Goregaokar [:manishearth]]

I already have a patch fwiw

Comment 5

[Manish Goregaokar [:manishearth]]

https://github.com/servo/servo/pull/17809

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Thank you Manish!

Comment 7

[Emilio Cobos Álvarez (:emilio)]

The test case should probably be landed.

Comment 8

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1382672 - Add crashtest for discrete animation between system fonts on stylo;

Review commit: https://reviewboard.mozilla.org/r/159564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159564/

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8888582 [details]
Bug 1382672 - Add crashtest for discrete animation between system fonts on stylo;

https://reviewboard.mozilla.org/r/159564/#review164936

Thanks :).

r=me

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c316420a58e8
Add crashtest for discrete animation between system fonts on stylo; r=emilio

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c316420a58e8