1382682 - Collect scroll metadata for APZ in layers-free webrender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

In layers-free webrender we don't have a layer tree to walk. Instead we need to pick out the scroll metadata from walking the display list. It's not entirely clear to me what sort of structure we'll want to use to ship over the metadata to the compositor (whether to re-use the WebRenderScrollData from webrender layers or some variation of it) but in the name of incremental progress I'd like to at least collect the metadata.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1382682 - Move ViewIDForASR into nsLayoutUtils for reuse.

Review commit: https://reviewboard.mozilla.org/r/159314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159314/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1382682 - Update a param to be a const-ptr.

Review commit: https://reviewboard.mozilla.org/r/159316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159316/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1382682 - Collect scroll metadata from the display list in layers-free webrender.

Review commit: https://reviewboard.mozilla.org/r/159318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159318/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1382682 - Collect scroll metadata for scrollinfo layers as well.

Review commit: https://reviewboard.mozilla.org/r/159320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159320/

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c64cf82d1b3f558c3d3a25a02f4c9b73208a06de includes these patches.

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8888366 [details]
Bug 1382682 - Move ViewIDForASR into nsLayoutUtils for reuse.

https://reviewboard.mozilla.org/r/159314/#review164912

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 8888367 [details]
Bug 1382682 - Update a param to be a const-ptr.

https://reviewboard.mozilla.org/r/159316/#review164914

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8888368 [details]
Bug 1382682 - Collect scroll metadata from the display list in layers-free webrender.

https://reviewboard.mozilla.org/r/159318/#review164916

Comment 9

[Markus Stange [:mstange]]

Comment on attachment 8888369 [details]
Bug 1382682 - Collect scroll metadata for scrollinfo layers as well.

https://reviewboard.mozilla.org/r/159320/#review164918

Comment 10

[Markus Stange [:mstange]]

Comment on attachment 8888368 [details]
Bug 1382682 - Collect scroll metadata from the display list in layers-free webrender.

https://reviewboard.mozilla.org/r/159318/#review164922

::: gfx/layers/wr/WebRenderLayerManager.cpp:256
(Diff revision 1)
> +          // information into the WR display list directly.
> +          Maybe<ScrollMetadata> metadata = asr->mScrollableFrame->ComputeScrollMetadata(
> +              nullptr, item->ReferenceFrame(),
> +              ContainerLayerParameters(), nullptr);
> +          MOZ_ASSERT(metadata);
> +          mScrollMetadata[id] = metadata.ref();

Maybe change this to
mScrollMetadata[id] = *metadata;
for consistency with the next patch

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8888368 [details]
Bug 1382682 - Collect scroll metadata from the display list in layers-free webrender.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159318/diff/1-2/

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8888369 [details]
Bug 1382682 - Collect scroll metadata for scrollinfo layers as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159320/diff/1-2/

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8888368 [details]
Bug 1382682 - Collect scroll metadata from the display list in layers-free webrender.

https://reviewboard.mozilla.org/r/159318/#review164922

> Maybe change this to
> mScrollMetadata[id] = *metadata;
> for consistency with the next patch

Fixed, thanks

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2bfff6c59b1
Move ViewIDForASR into nsLayoutUtils for reuse. r=mstange
https://hg.mozilla.org/integration/autoland/rev/7b1329006eda
Update a param to be a const-ptr. r=mstange
https://hg.mozilla.org/integration/autoland/rev/975390c67975
Collect scroll metadata from the display list in layers-free webrender. r=mstange
https://hg.mozilla.org/integration/autoland/rev/8949e22b8033
Collect scroll metadata for scrollinfo layers as well. r=mstange

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a2bfff6c59b1
https://hg.mozilla.org/mozilla-central/rev/7b1329006eda
https://hg.mozilla.org/mozilla-central/rev/975390c67975
https://hg.mozilla.org/mozilla-central/rev/8949e22b8033