Refactor Zone::setGCState to assert previous state

RESOLVED FIXED in Firefox 56

Status

()

Core
JavaScript: GC
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

55 Branch
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
Pretty much everywhere we call this we also assert the previous state.  It makes sense to do this as part of the method.
(Assignee)

Comment 1

6 months ago
Created attachment 8888382 [details] [diff] [review]
bug1382720-change-zone-state
Attachment #8888382 - Flags: review?(sphink)
Attachment #8888382 - Flags: review?(sphink) → review+

Comment 2

6 months ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9d10df4a135
Move zone state assertion into state update method r=sfink

Comment 3

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d9d10df4a135
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.