Closed
Bug 1382722
Opened 7 years ago
Closed 7 years ago
Debugger GC notification is triggered more than once when compacting
Categories
(Core :: JavaScript: GC, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
2.59 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Currently Zone::setGCState() triggers debugger GC notifications when the state is set to Finished. This is not ideal because the state may change to Compacting and back to Finished after this point. I don't think this actually causes any problems because all we do is put the GC number into a set if a debugger is observing GCs, but we should still do this once at the end of GC instead.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8888384 -
Flags: review?(sphink)
|
||
Updated•7 years ago
|
Attachment #8888384 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/07888792204b Trigger debugger GC notification once at the end of GC r=sfink
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/07888792204b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•