Try: Cannot run Talos on linux64-pgo

RESOLVED FIXED in mozilla56

Status

Firefox Build System
Task Configuration
RESOLVED FIXED
10 months ago
3 months ago

People

(Reporter: jlorenzo, Assigned: jlorenzo)

Tracking

unspecified
mozilla56
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
One action needed to retire Talos on opt builds (in favor of pgo) is to be able to run talos on Try.

At the moment, on the tc-migration branch, we're able to trigger talos on win{32,64}-pgo, but not on linux[1].

I guess there's a change to do in try_option_syntax.py[2]. I'm looking into it. 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd16b920f67c453ad863d1673f733231bc2de91e&filter-tier=1&filter-tier=2&filter-tier=3
[2] https://dxr.mozilla.org/mozilla-central/rev/1b065ffd8a535a0ad4c39a912af18e948e6a42c1/taskcluster/taskgraph/try_option_syntax.py
(Assignee)

Updated

10 months ago
Blocks: 691673
(Assignee)

Comment 1

10 months ago
I see Talos doesn't run on Linux 32[1]. Renaming bug accordingly.

[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=talos&fromchange=30ea2905130e85f9e1d8d56fa3097901eec6514b&tochange=60a5308fa987676fa5ed9fd5b3ad6c9938af0539
Summary: Try: Cannot run Talos on linux{,64}-pgo → Try: Cannot run Talos on linux64-pgo
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Depends on: 1332255

Comment 4

10 months ago
mozreview-review
Comment on attachment 8889418 [details]
Bug 1382725 - Try: Make Talos run on linux64-pgo

https://reviewboard.mozilla.org/r/160454/#review165710

::: taskcluster/taskgraph/transforms/tests.py
(Diff revision 1)
> -def remove_linux_pgo_try_talos(config, tests):
> -    """linux64-pgo talos tests don't run on try."""
> -    def predicate(test):
> -        return not(
> -            test['test-platform'] == 'linux64-pgo/opt' and
> -            (test['suite'] == 'talos' or test['suite'] == 'awsy') and

I wasn't sure what to do about the AWSY support. Do you know?
(Assignee)

Comment 5

10 months ago
Comment on attachment 8889418 [details]
Bug 1382725 - Try: Make Talos run on linux64-pgo

Clearing review request while we discuss whether AWSY should run on try.
Attachment #8889418 - Flags: review?(catlee)
(Assignee)

Comment 6

10 months ago
AWSY was filtered out by remove_linux_pgo_try_talos() in bug 1272113. I don't know what's changed since then, however, I know removing the whole function doesn't make awsy appear on try[1]. My guess is that's because awsy isn't listed at [2]

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b424017947628249cdc05ab01c36b5822513cda&filter-tier=1&filter-tier=2&filter-tier=3
[2] https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/taskcluster/ci/test/test-platforms.yml#75
See Also: → bug 1272113

Comment 7

10 months ago
It was set to make sure awsy won't run on pgo build accidentally. As long as test-platforms.yml is not changed it should be safe to remove.
(Assignee)

Comment 8

10 months ago
Comment on attachment 8889418 [details]
Bug 1382725 - Try: Make Talos run on linux64-pgo

Thank you for the background, Paul :)

Looks like we're good for another round of review.
Attachment #8889418 - Flags: review?(catlee)
(Assignee)

Updated

10 months ago
Blocks: 1382214

Comment 9

10 months ago
mozreview-review
Comment on attachment 8889418 [details]
Bug 1382725 - Try: Make Talos run on linux64-pgo

https://reviewboard.mozilla.org/r/160454/#review166448
Attachment #8889418 - Flags: review?(catlee) → review+

Comment 10

10 months ago
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16d3556f4905
Try: Make Talos run on linux64-pgo r=catlee

Comment 11

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/16d3556f4905
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Updated

3 months ago
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.