Closed Bug 1382725 Opened 4 years ago Closed 4 years ago

Try: Cannot run Talos on linux64-pgo

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla56

People

(Reporter: u504868, Assigned: u504868)

References

Details

Attachments

(1 file)

One action needed to retire Talos on opt builds (in favor of pgo) is to be able to run talos on Try.

At the moment, on the tc-migration branch, we're able to trigger talos on win{32,64}-pgo, but not on linux[1].

I guess there's a change to do in try_option_syntax.py[2]. I'm looking into it. 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd16b920f67c453ad863d1673f733231bc2de91e&filter-tier=1&filter-tier=2&filter-tier=3
[2] https://dxr.mozilla.org/mozilla-central/rev/1b065ffd8a535a0ad4c39a912af18e948e6a42c1/taskcluster/taskgraph/try_option_syntax.py
Blocks: 691673
I see Talos doesn't run on Linux 32[1]. Renaming bug accordingly.

[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=talos&fromchange=30ea2905130e85f9e1d8d56fa3097901eec6514b&tochange=60a5308fa987676fa5ed9fd5b3ad6c9938af0539
Summary: Try: Cannot run Talos on linux{,64}-pgo → Try: Cannot run Talos on linux64-pgo
Depends on: 1332255
Comment on attachment 8889418 [details]
Bug 1382725 - Try: Make Talos run on linux64-pgo

https://reviewboard.mozilla.org/r/160454/#review165710

::: taskcluster/taskgraph/transforms/tests.py
(Diff revision 1)
> -def remove_linux_pgo_try_talos(config, tests):
> -    """linux64-pgo talos tests don't run on try."""
> -    def predicate(test):
> -        return not(
> -            test['test-platform'] == 'linux64-pgo/opt' and
> -            (test['suite'] == 'talos' or test['suite'] == 'awsy') and

I wasn't sure what to do about the AWSY support. Do you know?
Comment on attachment 8889418 [details]
Bug 1382725 - Try: Make Talos run on linux64-pgo

Clearing review request while we discuss whether AWSY should run on try.
Attachment #8889418 - Flags: review?(catlee)
AWSY was filtered out by remove_linux_pgo_try_talos() in bug 1272113. I don't know what's changed since then, however, I know removing the whole function doesn't make awsy appear on try[1]. My guess is that's because awsy isn't listed at [2]

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b424017947628249cdc05ab01c36b5822513cda&filter-tier=1&filter-tier=2&filter-tier=3
[2] https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/taskcluster/ci/test/test-platforms.yml#75
See Also: → 1272113
It was set to make sure awsy won't run on pgo build accidentally. As long as test-platforms.yml is not changed it should be safe to remove.
Comment on attachment 8889418 [details]
Bug 1382725 - Try: Make Talos run on linux64-pgo

Thank you for the background, Paul :)

Looks like we're good for another round of review.
Attachment #8889418 - Flags: review?(catlee)
Blocks: 1382214
Comment on attachment 8889418 [details]
Bug 1382725 - Try: Make Talos run on linux64-pgo

https://reviewboard.mozilla.org/r/160454/#review166448
Attachment #8889418 - Flags: review?(catlee) → review+
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16d3556f4905
Try: Make Talos run on linux64-pgo r=catlee
https://hg.mozilla.org/mozilla-central/rev/16d3556f4905
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.