Closed Bug 1382749 Opened 2 years ago Closed 2 years ago

remove the old implementation of add-on signing

Categories

(Toolkit :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: keeler, Assigned: keeler)

References

Details

Attachments

(1 file)

See https://groups.google.com/d/msg/mozilla.dev.platform/vnrY1nkh55w/3dcQiyvYBgAJ

Long story short is nothing appears to be using the "old" way of doing add-on signing and we can remove it.
Comment on attachment 8897997 [details]
bug 1382749 - remove the "old way" of signing add-ons

https://reviewboard.mozilla.org/r/169294/#review174670

Looks good. Thanks for braving the xpinstall tests.
Attachment #8897997 - Flags: review?(dtownsend) → review+
Hi Michael - just wanted to make sure you saw this review request (for the libjar parts, really). If you're busy, feel free to redirect this.
Flags: needinfo?(mwu.code)
No objections to it, but I've never really looked at those parts either. Not active with the project right now so I don't know who to redirect to.
Flags: needinfo?(mwu.code)
Oh, sorry - didn't realize. I'll redirect to Aaron.
Attachment #8897997 - Flags: review?(mwu.code) → review?(aklotz)
Hi Aaron - just wanted to ping you about this. I really only need review on the libjar parts. Feel free to redirect (although I already asked :mwu, who is the only other person listed at https://wiki.mozilla.org/Modules/All#libjar )
Flags: needinfo?(aklotz)
Comment on attachment 8897997 [details]
bug 1382749 - remove the "old way" of signing add-ons

https://reviewboard.mozilla.org/r/169294/#review179124
Attachment #8897997 - Flags: review?(aklotz) → review+
Sorry for the delay.
Flags: needinfo?(aklotz)
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a4aac2956cf
remove the "old way" of signing add-ons r=aklotz,mossop
https://hg.mozilla.org/mozilla-central/rev/1a4aac2956cf
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.