1382749 - remove the old implementation of add-on signing

Status: RESOLVED FIXED

(Toolkit :: General, enhancement)

Description

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

See https://groups.google.com/d/msg/mozilla.dev.platform/vnrY1nkh55w/3dcQiyvYBgAJ

Long story short is nothing appears to be using the "old" way of doing add-on signing and we can remove it.

Comment 1

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: bug 1382749 - remove the "old way" of signing add-ons

In particular, this removes the nsIZipReader.getSigningCert API.

Review commit: https://reviewboard.mozilla.org/r/169294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169294/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8897997 [details]
bug 1382749 - remove the "old way" of signing add-ons

https://reviewboard.mozilla.org/r/169294/#review174670

Looks good. Thanks for braving the xpinstall tests.

Comment 3

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Hi Michael - just wanted to make sure you saw this review request (for the libjar parts, really). If you're busy, feel free to redirect this.

Comment 4

[Michael Wu [:mwu]]

No objections to it, but I've never really looked at those parts either. Not active with the project right now so I don't know who to redirect to.

Comment 5

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Oh, sorry - didn't realize. I'll redirect to Aaron.

Comment 6

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Hi Aaron - just wanted to ping you about this. I really only need review on the libjar parts. Feel free to redirect (although I already asked :mwu, who is the only other person listed at https://wiki.mozilla.org/Modules/All#libjar )

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8897997 [details]
bug 1382749 - remove the "old way" of signing add-ons

https://reviewboard.mozilla.org/r/169294/#review179124

Comment 8

[(No longer employed by Mozilla) Aaron Klotz]

Sorry for the delay.

Comment 9

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 8897997 [details]
bug 1382749 - remove the "old way" of signing add-ons

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169294/diff/1-2/

Comment 10

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Thanks for the reviews. Try is pretty orange these days, but hopefully these two runs demonstrate this patch doesn't add any new failures:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab34196ad84daf119fa8670b262e64992c55806b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a537ccf17ad59bbe1f45f7d7afa2888df8dba6a

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a4aac2956cf
remove the "old way" of signing add-ons r=aklotz,mossop

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1a4aac2956cf