Closed Bug 1382749 Opened 3 years ago Closed 3 years ago
remove the old implementation of add-on signing
59 bytes, text/x-review-board-request
See https://groups.google.com/d/msg/mozilla.dev.platform/vnrY1nkh55w/3dcQiyvYBgAJ Long story short is nothing appears to be using the "old" way of doing add-on signing and we can remove it.
Comment on attachment 8897997 [details] bug 1382749 - remove the "old way" of signing add-ons https://reviewboard.mozilla.org/r/169294/#review174670 Looks good. Thanks for braving the xpinstall tests.
Attachment #8897997 - Flags: review?(dtownsend) → review+
Hi Michael - just wanted to make sure you saw this review request (for the libjar parts, really). If you're busy, feel free to redirect this.
No objections to it, but I've never really looked at those parts either. Not active with the project right now so I don't know who to redirect to.
Oh, sorry - didn't realize. I'll redirect to Aaron.
3 years ago
Attachment #8897997 - Flags: review?(mwu.code) → review?(aklotz)
Hi Aaron - just wanted to ping you about this. I really only need review on the libjar parts. Feel free to redirect (although I already asked :mwu, who is the only other person listed at https://wiki.mozilla.org/Modules/All#libjar )
Comment on attachment 8897997 [details] bug 1382749 - remove the "old way" of signing add-ons https://reviewboard.mozilla.org/r/169294/#review179124
Attachment #8897997 - Flags: review?(aklotz) → review+
Sorry for the delay.
Thanks for the reviews. Try is pretty orange these days, but hopefully these two runs demonstrate this patch doesn't add any new failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab34196ad84daf119fa8670b262e64992c55806b https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a537ccf17ad59bbe1f45f7d7afa2888df8dba6a
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/1a4aac2956cf remove the "old way" of signing add-ons r=aklotz,mossop
3 years ago
You need to log in before you can comment on or make changes to this bug.