Closed Bug 1382754 Opened 2 years ago Closed 2 years ago
Update Screenshots to version 10
59 bytes, text/x-review-board-request
Changelog: https://github.com/mozilla-services/screenshots/blob/v10.4.0-export/CHANGELOG.md#version-1080 - Update privacy notice URL - Don't throw 'haywire' errors when a page is resized after taking a shot  https://github.com/mozilla-services/screenshots/issues/3135  https://github.com/mozilla-services/screenshots/issues/3153
Assignee: nobody → jhirsch
Pushed to Try with Talos x5: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9666a57111f61da787b4ba626a248a75983ca97 Also pushed the mozilla-central base commit with 5 Talos retries, so we can make a reliable comparison: https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=313cef6ff045648291e83e88e665ba0183c775e6 Note that uplifting this patch would also require uplifting the patch from bug 1381132.
Comment on attachment 8888449 [details] Bug 1382754 - Export Screenshots version 10.8.0 to Firefox; https://reviewboard.mozilla.org/r/159402/#review165212
Attachment #8888449 - Flags: review+
Attachment #8888449 - Flags: review?(kmaglione+bmo)
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a112a1a624cd Export Screenshots version 10.8.0 to Firefox; r=mossop
Please request Beta approval on this when you get a chance.
Comment on attachment 8888449 [details] Bug 1382754 - Export Screenshots version 10.8.0 to Firefox; Approval Request Comment [Feature/Bug causing the regression]: Screenshots [User impact if declined]: - See security bug 1380616 - Users who haven't tried Screenshots before will see a Screenshots toolbar button with an empty grey spot instead of an icon [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Softvision has tested. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Changes are to the WebExtension portion of Screenshots [String changes made/needed]: None
Attachment #8888449 - Flags: approval-mozilla-beta?
Comment on attachment 8888449 [details] Bug 1382754 - Export Screenshots version 10.8.0 to Firefox; screenshots update for 55.0b12
Attachment #8888449 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.