1382754 - Update Screenshots to version 10.8.0

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Changelog:

https://github.com/mozilla-services/screenshots/blob/v10.4.0-export/CHANGELOG.md#version-1080

- Update privacy notice URL[1]
- Don't throw 'haywire' errors when a page is resized after taking a shot[2]

[1] https://github.com/mozilla-services/screenshots/issues/3135
[2] https://github.com/mozilla-services/screenshots/issues/3153

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1382754 - Export Screenshots version 10.8.0 to Firefox;

Review commit: https://reviewboard.mozilla.org/r/159402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159402/

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Pushed to Try with Talos x5:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9666a57111f61da787b4ba626a248a75983ca97

Also pushed the mozilla-central base commit with 5 Talos retries, so we can make a reliable comparison:
https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=313cef6ff045648291e83e88e665ba0183c775e6

Note that uplifting this patch would also require uplifting the patch from bug 1381132.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8888449 [details]
Bug 1382754 - Export Screenshots version 10.8.0 to Firefox;

https://reviewboard.mozilla.org/r/159402/#review165212

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Thanks, Mossop!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a112a1a624cd
Export Screenshots version 10.8.0 to Firefox; r=mossop

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a112a1a624cd

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 8

[Wil Clouser [:clouserw]]

Comment on attachment 8888449 [details]
Bug 1382754 - Export Screenshots version 10.8.0 to Firefox;

Approval Request Comment

[Feature/Bug causing the regression]:
Screenshots

[User impact if declined]:
- See security bug 1380616
- Users who haven't tried Screenshots before will see a Screenshots toolbar button with an empty grey spot instead of an icon

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]:
Softvision has tested.

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
Changes are to the WebExtension portion of Screenshots

[String changes made/needed]:
None

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8888449 [details]
Bug 1382754 - Export Screenshots version 10.8.0 to Firefox;

screenshots update for 55.0b12

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/285727e97c4c