Closed Bug 1382754 Opened 2 years ago Closed 2 years ago

Update Screenshots to version 10.8.0

Categories

(Firefox :: Screenshots, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox55 + fixed
firefox56 - fixed

People

(Reporter: _6a68, Assigned: _6a68)

References

Details

Attachments

(1 file)

Assignee: nobody → jhirsch
Pushed to Try with Talos x5:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9666a57111f61da787b4ba626a248a75983ca97

Also pushed the mozilla-central base commit with 5 Talos retries, so we can make a reliable comparison:
https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=313cef6ff045648291e83e88e665ba0183c775e6

Note that uplifting this patch would also require uplifting the patch from bug 1381132.
Comment on attachment 8888449 [details]
Bug 1382754 - Export Screenshots version 10.8.0 to Firefox;

https://reviewboard.mozilla.org/r/159402/#review165212
Attachment #8888449 - Flags: review+
Thanks, Mossop!
Keywords: checkin-needed
Attachment #8888449 - Flags: review?(kmaglione+bmo)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a112a1a624cd
Export Screenshots version 10.8.0 to Firefox; r=mossop
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a112a1a624cd
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Please request Beta approval on this when you get a chance.
Flags: needinfo?(jhirsch)
Target Milestone: --- → mozilla56
Depends on: 1381132
Comment on attachment 8888449 [details]
Bug 1382754 - Export Screenshots version 10.8.0 to Firefox;

Approval Request Comment

[Feature/Bug causing the regression]:
Screenshots

[User impact if declined]:
- See security bug 1380616
- Users who haven't tried Screenshots before will see a Screenshots toolbar button with an empty grey spot instead of an icon

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]:
Softvision has tested.

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
Changes are to the WebExtension portion of Screenshots

[String changes made/needed]:
None
Attachment #8888449 - Flags: approval-mozilla-beta?
Comment on attachment 8888449 [details]
Bug 1382754 - Export Screenshots version 10.8.0 to Firefox;

screenshots update for 55.0b12
Attachment #8888449 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(jhirsch)
Target Milestone: mozilla56 → Firefox 56
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.