1382756 - Display FxA avatar in settings

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, enhancement)

Description

[Vijay Budhram]

If a user is signed in and has added an avatar, display that avatar in the settings panel. If no avatar is set, then display the placeholder avatar used in FxA website.

Comment 1

[Vijay Budhram]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3071

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8900547 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3071

Review left on GitHub. Please re-flag when you need another look!

Comment 3

[Vijay Budhram]

Comment on attachment 8900547 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3071

Thanks for review :rnewman. I have made the code updates you recommended and think this is ready for another r.

I have also flagged for ui review and to get updated graphics.

Comment 4

[Robin Andersen [:tecgirl]]

Attachment: FxA.zip

Sync and Firefox logo (solid light grey) assets.

Comment 5

[Robin Andersen [:tecgirl]]

Attachment: FxA-Sync-Blue.zip

Comment 6

[Vijay Budhram]

This patch as landed in master, https://github.com/mozilla-mobile/firefox-ios/pull/3071. Thanks all for reviews!