Closed Bug 1382774 Opened 2 years ago Closed 2 years ago

Fetch Android Gradle dependencies from jcenter rather than Maven Central

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Product:
Firefox Build System
Component:
Android Studio and Gradle Integration
Type:
enhancement
Priority:
Not set

Tracking

(firefox56 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(2 files)

Bug 1382774 - Pre: Don't fail |mach android gradle-dependencies|.
59 bytes, text/x-review-board-request
Details
Bug 1382774 - Configure android-gradle-dependencies to use jcenter instead of central.
59 bytes, text/x-review-board-request
Details 
Google is moving away from Maven Central and towards maven.google.com and jcenter.  We need to follow to pull recent dependencies in the Android Gradle dependencies job.
Comment on attachment 8888472 [details]
Bug 1382774 - Pre: Don't fail |mach android gradle-dependencies|.

https://reviewboard.mozilla.org/r/159418/#review165126
Attachment #8888472 - Flags: review?(s.kaspari) → review+
Comment on attachment 8888473 [details]
Bug 1382774 - Configure android-gradle-dependencies to use jcenter instead of central.

https://reviewboard.mozilla.org/r/159420/#review165128
Attachment #8888473 - Flags: review?(s.kaspari) → review+
LGTM. I'll try to land them to unblock bug 1380639. :)
Comment on attachment 8888473 [details]
Bug 1382774 - Configure android-gradle-dependencies to use jcenter instead of central.

https://reviewboard.mozilla.org/r/159420/#review165130

::: taskcluster/docker/android-gradle-build/bin/after.sh:17
(Diff revision 1)
>  # Not yet.  See notes on tooltool below.
>  # cp -R /root/.android-sdk android-sdk-linux
>  # tar cJf android-sdk-linux.tar.xz android-sdk-linux
>  
> -cp -R /workspace/nexus/storage/central jcentral
> +cp -R /workspace/nexus/storage/jcenter jcentral
>  tar cJf jcentral.tar.xz jcentral

Because of the name "jcentral" I thought we'd pull dependencies from jcenter already. :)
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/636f4f483359
Pre: Don't fail |mach android gradle-dependencies|. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/2b78ed90d463
Configure android-gradle-dependencies to use jcenter instead of central. r=sebastian
(In reply to Sebastian Kaspari (:sebastian) from comment #8)
> Comment on attachment 8888473 [details]
> Bug 1382774 - Configure android-gradle-dependencies to use jcenter instead
> of central.
> 
> https://reviewboard.mozilla.org/r/159420/#review165130
> 
> ::: taskcluster/docker/android-gradle-build/bin/after.sh:17
> (Diff revision 1)
> >  # Not yet.  See notes on tooltool below.
> >  # cp -R /root/.android-sdk android-sdk-linux
> >  # tar cJf android-sdk-linux.tar.xz android-sdk-linux
> >  
> > -cp -R /workspace/nexus/storage/central jcentral
> > +cp -R /workspace/nexus/storage/jcenter jcentral
> >  tar cJf jcentral.tar.xz jcentral
> 
> Because of the name "jcentral" I thought we'd pull dependencies from jcenter
> already. :)

Yeah, me too.  I must have just been confused, since jcentral isn't jcenter and isn't Maven Central :)
https://hg.mozilla.org/mozilla-central/rev/636f4f483359
https://hg.mozilla.org/mozilla-central/rev/2b78ed90d463
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 56 → mozilla56
You need to log in before you can comment on or make changes to this bug.