Closed Bug 1382862 Opened 2 years ago Closed 2 years ago

Remove GeckoViewFragment

Categories

(Firefox for Android :: General, enhancement)

All
Android
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

No description provided.
GeckoViewFragment was more of a hack for GeckoApp-based custom tabs, and
if we want to provide a fragment implementation for GeckoView, I think
it'll look a lot different than today's GeckoViewFragment. So for now, I
think it's best to revert the changes that added GeckoViewFragment, and
that also simplifies GeckoView lifecycle management.
Attachment #8888851 - Flags: review?(droeh)
Comment on attachment 8888851 [details] [diff] [review]
Remove GeckoViewFragment (v1)

Review of attachment 8888851 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8888851 - Flags: review?(droeh) → review+
https://hg.mozilla.org/mozilla-central/rev/cb3966784bef
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.