Closed
Bug 1382862
Opened 7 years ago
Closed 7 years ago
Remove GeckoViewFragment
Categories
(Firefox for Android Graveyard :: General, enhancement)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(1 file)
17.08 KB,
patch
|
droeh
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
GeckoViewFragment was more of a hack for GeckoApp-based custom tabs, and if we want to provide a fragment implementation for GeckoView, I think it'll look a lot different than today's GeckoViewFragment. So for now, I think it's best to revert the changes that added GeckoViewFragment, and that also simplifies GeckoView lifecycle management.
Attachment #8888851 -
Flags: review?(droeh)
Comment 2•7 years ago
|
||
Comment on attachment 8888851 [details] [diff] [review] Remove GeckoViewFragment (v1) Review of attachment 8888851 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8888851 -
Flags: review?(droeh) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cb3966784bef Remove GeckoViewFragment; r=droeh
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cb3966784bef
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•