Closed Bug 1382863 Opened 2 years ago Closed 2 years ago

Undefined symbols for architecture x86_64 "vtable for mozilla::dom::MessagePortChild"

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: bradwerth, Assigned: bradwerth)

Details

Attachments

(1 file)

Bug 1382863 Part 1: Move MessagePortChild constructor out of inline, creating a vtable needed for clang compilation.
59 bytes, text/x-review-board-request
baku
: review+
Details 
macOS clang compilation fails with:

Undefined symbols for architecture x86_64:
  "vtable for mozilla::dom::MessagePortChild", referenced from:
    mozilla::dom::MessagePortChild::MessagePortChild() in BackgroundChildImpl.o
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.

And it appears that this explanation is, in fact, the case.
Attachment #8888553 - Flags: review?(overholt)
You want baku to review this.
Attachment #8888553 - Flags: review?(overholt) → review?(amarchesini)
Comment on attachment 8888553 [details]
Bug 1382863 Part 1: Move MessagePortChild constructor out of inline, creating a vtable needed for clang compilation.

https://reviewboard.mozilla.org/r/159530/#review165014
Attachment #8888553 - Flags: review?(amarchesini) → review+
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e853e81c2be
Part 1: Move MessagePortChild constructor out of inline, creating a vtable needed for clang compilation. r=baku
https://hg.mozilla.org/mozilla-central/rev/4e853e81c2be
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.