1382863 - Undefined symbols for architecture x86_64 "vtable for mozilla::dom::MessagePortChild"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Brad Werth [:bradwerth]]

macOS clang compilation fails with:

Undefined symbols for architecture x86_64:
  "vtable for mozilla::dom::MessagePortChild", referenced from:
    mozilla::dom::MessagePortChild::MessagePortChild() in BackgroundChildImpl.o
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.

And it appears that this explanation is, in fact, the case.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1382863 Part 1: Move MessagePortChild constructor out of inline, creating a vtable needed for clang compilation.

Review commit: https://reviewboard.mozilla.org/r/159530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159530/

Comment 2

[Brad Werth [:bradwerth]]

Comment on attachment 8888553 [details]
Bug 1382863 Part 1: Move MessagePortChild constructor out of inline, creating a vtable needed for clang compilation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159530/diff/1-2/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

You want baku to review this.

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8888553 [details]
Bug 1382863 Part 1: Move MessagePortChild constructor out of inline, creating a vtable needed for clang compilation.

https://reviewboard.mozilla.org/r/159530/#review165014

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e853e81c2be
Part 1: Move MessagePortChild constructor out of inline, creating a vtable needed for clang compilation. r=baku

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e853e81c2be