1382944 - stylo: Allow an assertion in test_display_mode.html and test_display_mode_reflow.html

Status: RESOLVED INVALID

(Core :: CSS Parsing and Computation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

this commit [1] somehow triggered an assertion in ReflowInput::CalculateHypotheticalPosition.

We should allow the assertion for now and later we should fix the cause of the assertion.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d42c8e6fc2d401c7700f67244e71a45b1f8cd9ef

I will open another bug to fix the assertion.


[1] https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d4b7fc921b88a8416c656e3ee6a893479b463fc4&filter-searchStr=mochitest-chrome-style

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1382944 - Allow an assertion in test_display_mode.html and test_display_mode_reflow.html on stylo.

A change[1] for browser triggered an assertion
'inline-size less than zero: 'aContainingBlockISize >= 0' in
ReflowInput::CalculateHypotheticalPosition, we allow the assertion for now
and will fix it later in another bug.

[1] https://hg.mozilla.org/integration/autoland/rev/d4b7fc921b88a8416c656e3ee6a893479b463fc4

Review commit: https://reviewboard.mozilla.org/r/159690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159690/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)
> this commit [1] somehow triggered an assertion in
> ReflowInput::CalculateHypotheticalPosition.
> 
> We should allow the assertion for now and later we should fix the cause of
> the assertion.
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=d42c8e6fc2d401c7700f67244e71a45b1f8cd9ef
> 
> I will open another bug to fix the assertion.

Filed bug 1382946.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)
> this commit [1] somehow triggered an assertion in
> ReflowInput::CalculateHypotheticalPosition.
> 
> We should allow the assertion for now and later we should fix the cause of
> the assertion.
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=d42c8e6fc2d401c7700f67244e71a45b1f8cd9ef

-p linux64-stylo seems not work on try.

I hope '--artifact' works fine for stylo.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=07cc17c11144365bb5c002a7d582cd6f11559e25

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Did not work the revision based on autoland.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6a17332b75bc36d3122c3fe1d5ac207c8cb5819

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8888665 [details]
Bug 1382944 - Allow an assertion in test_display_mode.html and test_display_mode_reflow.html on stylo.

Oh, the assertion seemed to happen on non-stylo build.
https://treeherder.mozilla.org/logviewer.html#?job_id=116218579&repo=autoland&lineNumber=7690

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Closing this is not a stylo issue.