138297 - Problems with editing filter rules and Quicklaunch.

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[laurel]

Using apr15 - 17 branch win98, win2000

When in Quicklaunch, filters may fire on out-of-date criteria/rules information.
 In the cases seen, filters have been edited and user has not exited quicklaunch
or switched profiles.  

Two situations/results have been seen:
1.  Gayatri found that when she edited a filter to complete change a criteria
and text string value, messages matching the old criteria continued to filter
(all OR filters).  Any messages matching the new criteria would not fire the
filters.  We tried adding a new filter for test and that, too, would not fire. 
The filter UI and the filter rules.dat file were both reflecting only the new
edits, no cruft of the old criteria string/info shown.  Upon exiting
QuickLaunch, the situation corrected.   Her situation  was noticed over a couple
days, a few edits.
2.  With Quicklaunch engaged, I edited filter strings (changing part of the
strin), added criteria lines and added a filter (all OR filters).  Messages
matching the new information were acknowledged and fired the filters.  I quit
app, but did not exit quicklaunch or change profiles.  When I launched again,
messages matching the new criteria fired the filters.  Messages matching older
string criteria also fired the filters.  I edited again and completely wiped out
the older criteria strings, and adding new criteria line.  Both new information
and older strings in message headers would fire the filters. I exited the app,
but not Quicklaunch, did not switch profiles, then launched again.  Now the
older string (two different cases of older string information) would not fire
and all new criteria/strings did fire.

So, we have a problem with updating cached filter information with Quicklaunch
unless someone exits quicklaunch or (so naving said) changes profiles.

Comment 1

[laurel]

I have just tried several more times to reproduce the problem using same steps
and it behaved beautifully... argh.

Comment 2

[laurel]

I just hit this again, where I'd added two new filters. Only one of the two new
ones fired, the old ones fired.  Once I exited QuickLaunch, both the newer
filters fired.    Tried the same thing again and all was okay. Again, argh!

Comment 3

[laurel]

I just had a problem where I got some filtered messages labeled a value 4/blue
and it didn't match the only filter I had where I specified a 4 label as action.
I'd, in previous sessions, added a couple filters, deleted some filters and
disabled a couple filters.  All seemed to work fine at the time.  I had not
exited QuickLaunch throughout this time.  Once I exited, exited QuickLaunch, I
tried again and the incorrect labeling occurred. Once I exited again, disabled
Quicklaunch and restarted, I no longer got the incorrect labeling. Whew.  Let's
see if I can do this one again!

Comment 4

[Peter Trudelle]

Nominating for MachV. Is this happening with a single profile, or only in the
multi-profile case?

Comment 5

[Peter Trudelle]

NavinG, can you verify whether this happens in single-profile case?

Comment 6

[laurel]

The instances I've seen are when I'm NOT switching profiles, using the same
profile.  Anytime I need to switch profiles, I always disable QuickLaunch.  I
verified the same is true with Gayatri's instances -- she never switches
profiles and had problems when she edits filters.

Comment 7

[Navin Gupta]

ok, I will try to reproduce. Single profile case was having problems, that
is what I saw on gayatri's machine but we haven't been able to reproduce it 
yet.

Comment 8

[Navin Gupta]

Attachment: patch to not null out filterList for imap server

This bug is happening only for imap, atleast for people who are seeing it 
sometimes. I have not been able to reproduce it but I checked the code and
we were nulling out filterList on the imap server in CloseCachedConnections()
which will get called when we do exit in turbo mode because of session-logout.

If we launch the same profile again the Inbox was holding on to the old
filterList but if we open filter dialog we were creating a new filter list
for server. so there are two filter list objects which is bad! I think this
could be the reason why we are seeing this sometimes. 

Since we do want to cut shutdown leaks a good place to move this is when 
we are unloading server. So I added a setter to server to null out filter list
there. I generated a leak log and didn't see any related leaks. 


david, can you review.

Comment 9

[David :Bienvenu]

Comment on attachment 81589 [details] [diff] [review]
patch to not null out filterList for imap server

r=bienvenu (but shouldn't the description of the patch be "null out filter list
when unloading server"?)

Comment 10

[Navin Gupta]

you are right. 

Comment 11

[Scott MacGregor]

Comment on attachment 81589 [details] [diff] [review]
patch to not null out filterList for imap server

sr=mscott

Comment 12

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval fo checkin to the 1.0 branch. Pls check
this in today after you receive Drivers approval, then add fixed1.0.0 keyword.

Comment 13

[Navin Gupta]

ok laurel, here is how to reproduce this bug...

No turbo on now

1. Launch mail with a profile having an imap acct and some filters present (I
had all label filters).
2. Send a mail to this acct and receive it.
2. Now turn on turbo
3. File | Exit but don't exit turbo
4. launch mail with same profile again
5. Add a new filter ( I did label)
6. Send mail that matches the filter criteria and receive it

Expected : new filter should work

Actual : new filter doesn't work

I know these bugs are tough to reproduce, hope this helps. 

Comment 14

[laurel]

Thanks. I just tried your steps 3 times and the new filter didn't fail once
(three separate setups).  Will keep at it, though.

Comment 15

[Navin Gupta]

fixed on trunk. waiting for branch-approval from drivers

Comment 16

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 81589 [details] [diff] [review]
patch to not null out filterList for imap server

a=[e-mail] for branch checkin

Comment 17

[laurel]

Scenario listed in comment #13 verified on trunk: 2002-05-01-04 win98.

Comment 18

[Navin Gupta]

fixed on branch

Comment 19

[laurel]

Using today's branch 2002050206 with win98, I verified the scenario in comment
#13 . I turned the multi-profile pref from bug 141068 off when verifying, made
sure the pref worked to keep Quicklaunch running after exiting.  

I don't want to mark this verified on the branch until Gayatri gets a chance to
look at this fix since she has experienced the most consistent problems with her
filters and quicklaunch.  I will also keep testing to see if I can hit any
problems, since I did see random instances of filter problems prior to a fix.

Comment 20

[laurel]

Marking OK for branch, using may02 branch on win98 and win2000:
1.  Win2000: gayatri verified she is able to add and/or edit filters and changes
work fresh out of the gate with QuickLaunch on.  She did not muck with the new
pref, but had previously had consistent problems when adding or editing filters.
2.  Win98:  I have tried to get into filter problems with QuickLaunch on, have
tried with new pref ON and also with pref OFF.

Looks OK for branch. Will let you know if I run into anything further.