Closed
Bug 1383006
Opened 7 years ago
Closed 7 years ago
Stop shipping devtools/client/shared/shim/Services.js
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
Details
Attachments
(1 file)
The fake Services.js found in devtools/client/shared/shim is currently shipped with Firefox but we actually only use it when running out of Firefox. We should stop shipping this file, and also add a header comment clarifying its role.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=19e0f756b636d1e1054d788a163f209d1892ef4f
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8888731 [details] Bug 1383006 - remove devtools shim for services.js; https://reviewboard.mozilla.org/r/159760/#review165146 Sorry about the delay on this. In retrospect I should have cleared the review so I would have been re-notified by MozReview. This looks good. Thanks for doing it.
Attachment #8888731 -
Flags: review?(ttromey) → review+
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a36a9d7e962 remove devtools shim for services.js;r=tromey
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4a36a9d7e962
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•