Stop shipping devtools/client/shared/shim/Services.js

RESOLVED FIXED in Firefox 56

Status

P3
enhancement
RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

unspecified
Firefox 56

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

The fake Services.js found in devtools/client/shared/shim is currently shipped with Firefox but we actually only use it when running out of Firefox. 

We should stop shipping this file, and also add a header comment clarifying its role.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8888731 [details]
Bug 1383006 - remove devtools shim for services.js;

https://reviewboard.mozilla.org/r/159760/#review165146

Sorry about the delay on this.  In retrospect I should have cleared the review so I would have been re-notified by MozReview.

This looks good.  Thanks for doing it.
Attachment #8888731 - Flags: review?(ttromey) → review+

Comment 5

a year ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a36a9d7e962
remove devtools shim for services.js;r=tromey

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4a36a9d7e962
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.