Closed Bug 1383017 Opened 2 years ago Closed 2 years ago

Remove start-border for top-level message

Categories

(DevTools :: Console, enhancement)

enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(2 files)

In the new frontend, all the messages have a border-inline-start border.
This looks a bit weird for top=level messages (see attachment).
We should only show the border for in-group messages.
Comment on attachment 8890838 [details]
Bug 1383017 - Remove border for top-level messages.

https://reviewboard.mozilla.org/r/159824/#review167324

Nice

::: devtools/client/webconsole/new-console-output/components/message-indent.js:25
(Diff revision 1)
>  function getIndentElement(indent) {
>    return dom.span({
> +    "data-indent": indent,
>      className: "indent",
> -    style: {"width": indent * INDENT_WIDTH}
> +    style: {
> +      "--indent": indent + "px",

This variable can be removed? It doesn't appear to be used
Attachment #8890838 - Flags: review?(bgrinstead) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3cb981a0f37
Remove border for top-level messages. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/f3cb981a0f37
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox → DevTools
Assignee: nobody → nchevobbe
You need to log in before you can comment on or make changes to this bug.