Closed Bug 1383055 Opened 4 years ago Closed 4 years ago

Avoid a heap allocation per event during playback of blob images

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(2 files)

Factor out a FOR_EACH_EVENT macro
5.16 KB, patch
lsalzman
: review+
Details | Diff | Splinter Review
Add DoWithEvent
3.75 KB, patch
lsalzman
: review+
Details | Diff | Splinter Review 
The heap allocation is not needed and not doing it will also help reduce contention with other threads.
This will let us avoid duplicating the event list for the upcoming DoWithEvent function.
Assignee: nobody → jmuizelaar
Attachment #8888787 - Flags: review?(lsalzman)
Attached patch Add DoWithEvent — — Splinter Review 
Add DoWithEvent which switches over an event type, reads the event into a stack variable and calls a callable with that event as a parameter.

This avoids doing a heap allocation for every event that we play back.
Attachment #8888792 - Flags: review?(lsalzman)
Attachment #8888792 - Flags: review?(lsalzman) → review+
Attachment #8888787 - Flags: review?(lsalzman) → review+
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f148f75bfc05
Factor out a FOR_EACH_EVENT macro. r=lsalzman
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b5cf7fc54bf
RecordedEvent: Add DoWithEvent. r=lsalzman
https://hg.mozilla.org/mozilla-central/rev/f148f75bfc05
https://hg.mozilla.org/mozilla-central/rev/8b5cf7fc54bf
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.