The heap allocation is not needed and not doing it will also help reduce contention with other threads.
Created attachment 8888787 [details] [diff] [review] Factor out a FOR_EACH_EVENT macro This will let us avoid duplicating the event list for the upcoming DoWithEvent function.
Assignee: nobody → jmuizelaar
Attachment #8888787 - Flags: review?(lsalzman)
Created attachment 8888792 [details] [diff] [review] Add DoWithEvent Add DoWithEvent which switches over an event type, reads the event into a stack variable and calls a callable with that event as a parameter. This avoids doing a heap allocation for every event that we play back.
Attachment #8888792 - Flags: review?(lsalzman)
Attachment #8888792 - Flags: review?(lsalzman) → review+
Attachment #8888787 - Flags: review?(lsalzman) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f148f75bfc05 Factor out a FOR_EACH_EVENT macro. r=lsalzman https://hg.mozilla.org/integration/mozilla-inbound/rev/8b5cf7fc54bf RecordedEvent: Add DoWithEvent. r=lsalzman
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.