bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

JSON parsing error if "JSON Payload" is left empty

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: dustin, Assigned: dustin)

Tracking

Details

Attachments

(1 attachment)

I just tried to trigger a task that needed no input.  The trigger button dimmed and there was an exception in the console, but not visible onscreen -- so that's one thing to fix.  The exception was from trying to parse the JSON payload, which was an empty string.  Changing that to null worked fine.
Created attachment 8890419 [details] [review]
[treeherder] djmitche:bug1383085 > mozilla:master
(Assignee)

Updated

11 months ago
Flags: needinfo?(cdawson)

Updated

11 months ago
Flags: needinfo?(cdawson)
Attachment #8890419 - Flags: review?(cdawson)

Comment 3

11 months ago
Hey Dustin-- Would you reassign to me when you've made your updates?  Thanks!

Comment 4

11 months ago
Comment on attachment 8890419 [details] [review]
[treeherder] djmitche:bug1383085 > mozilla:master

Needs some formatting.  :)
Attachment #8890419 - Flags: review?(cdawson) → review-
(Assignee)

Updated

11 months ago
Attachment #8890419 - Flags: review- → review?(cdawson)
(Assignee)

Updated

11 months ago
Assignee: dustin → cdawson

Comment 5

11 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d7fc806d83567100b7a17d43efc79e2485927976
Bug 1383085 - handle actions with no schema

When an action has no schema, this hides the JSON payload field and
doesn't try to JSON.parse it.

Note that this still fails for schema = {}, since json-schema-defaults
returns `undefined` for that value.

Updated

11 months ago
Attachment #8890419 - Flags: review?(cdawson) → review+

Updated

11 months ago
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED

Updated

11 months ago
Assignee: cdawson → dustin
You need to log in before you can comment on or make changes to this bug.