Closed Bug 1383138 Opened 4 years ago Closed 4 years ago

'Bookmark all tabs' dialog is broken

Categories

(Firefox :: Bookmarks & History, defect, P1)

Product:
Firefox
Component:
Bookmarks & History
Version:
56 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 --- verified

People

(Reporter: Mathnerd314, Assigned: mak)

References

Details

(4 keywords, Whiteboard: [fxsearch])

Attachments

(2 files)

Screenshot
58.30 KB, image/png
Details
Bug 1383138 - 'Bookmark all tabs' dialog is broken with async Places transactions.
59 bytes, text/x-review-board-request
adw
: review+
Details 
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170721030204

Steps to reproduce:

1. Download latest Nightly (20170721030204) with clean profile
2. Open it, should be 3 first-run tabs
3. Right-click and select "Bookmark all tabs"
4. Dialog has only "Add bookmark" button"
5. Click button


Actual results:

Folder named '[Folder name]' was created in Bookmarks Menu. No bookmarks present in folder.


Expected results:

Dialog should have folder selector and text box for folder name. Created folder should have the 3 bookmarked tabs.
Component: Untriaged → Bookmarks & History
Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0da00124af43d44fed96133300ba5e32b0d821a8&tochange=0a4690dfd7b383e2f732210cf8906ce51a5b2433
Blocks: 1071513
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Ever confirmed: true
Keywords: regression
Priority: -- → P1
Whiteboard: [fxsearch]
Attached image Screenshot — 
I can repro this on current Mac Nightly.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Blocks: PlacesAsyncTransact
Comment on attachment 8890056 [details]
Bug 1383138 - 'Bookmark all tabs' dialog is broken with async Places transactions.

https://reviewboard.mozilla.org/r/161118/#review167182
Attachment #8890056 - Flags: review?(adw) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/79c3b71475c7
'Bookmark all tabs' dialog is broken with async Places transactions. r=adw
@Marco Bonardo [::mak],
No automated test?
Flags: needinfo?(mak77)
Don't you see browser_bookmarkProperties_bookmarkAllTabs.js?
Flags: needinfo?(mak77)
Aha sorry.
https://hg.mozilla.org/mozilla-central/rev/79c3b71475c7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I'm confirming that it's fixed, starting in Mozilla Firefox 56.0a1 (2017-07-28).
Thank you very much! I'm marking this bug as VERIFIED.
Severity: normal → major
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Keywords: dataloss, nightly-community, reproducible
QA Contact: Virtual
Depends on: 1385733
No longer depends on: 1385733
You need to log in before you can comment on or make changes to this bug.