Closed Bug 1383138 Opened 6 years ago Closed 5 years ago
'Bookmark all tabs' dialog is broken
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 Build ID: 20170721030204 Steps to reproduce: 1. Download latest Nightly (20170721030204) with clean profile 2. Open it, should be 3 first-run tabs 3. Right-click and select "Bookmark all tabs" 4. Dialog has only "Add bookmark" button" 5. Click button Actual results: Folder named '[Folder name]' was created in Bookmarks Menu. No bookmarks present in folder. Expected results: Dialog should have folder selector and text box for folder name. Created folder should have the 3 bookmarked tabs.
I can repro this on current Mac Nightly.
Comment on attachment 8890056 [details] Bug 1383138 - 'Bookmark all tabs' dialog is broken with async Places transactions. https://reviewboard.mozilla.org/r/161118/#review167182
Attachment #8890056 - Flags: review?(adw) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/79c3b71475c7 'Bookmark all tabs' dialog is broken with async Places transactions. r=adw
@Marco Bonardo [::mak], No automated test?
Don't you see browser_bookmarkProperties_bookmarkAllTabs.js?
I'm confirming that it's fixed, starting in Mozilla Firefox 56.0a1 (2017-07-28). Thank you very much! I'm marking this bug as VERIFIED.
You need to log in before you can comment on or make changes to this bug.