Closed Bug 1383155 Opened 2 years ago Closed 2 years ago

remove redundant SrcNoteType casts

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: tromey, Assigned: tromey)

Details

Attachments

(1 file)

While working on bug 1370648 I noticed code like:

SrcNoteType type = (SrcNoteType) SN_TYPE(sn);

However, the cast here is redundant, because SN_TYPE does it:

https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/js/src/frontend/SourceNotes.h#113

I think the redundant casts should be removed.
Comment on attachment 8888881 [details]
Bug 1383155 - remove redundant casts of SN_TYPE;

https://reviewboard.mozilla.org/r/159912/#review165284

Easy!
Attachment #8888881 - Flags: review?(jimb) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40b0b14356e1
remove redundant casts of SN_TYPE; r=jimb
https://hg.mozilla.org/mozilla-central/rev/40b0b14356e1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.