Closed Bug 1383204 Opened 3 years ago Closed 3 years ago

Support reflayers/nsDisplayRemote in layers-free webrender

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(4 files)

Right now we only support layers-free mode in a content prescontext, because at the time layers-free was added we didn't have support for a lot of items. However now we have the fallback path that paints stuff as images if it's not supported so we should be able to remove this restriction. However, before we do, we need to support the equivalent of reflayers in layers-free mode, because otherwise the UI process doesn't generate the "iframe" for the content process.

I also kinda want this for APZ purposes, because we'll need to glue together the scroll data from both processes for APZ to know what's going on.

[1] http://searchfox.org/mozilla-central/rev/3a3af33f513071ea829debdfbc628caebcdf6996/layout/painting/nsDisplayList.cpp#2096-2098
I don't know if we want this patch or not. I'm ok with leaving it out if you don't want to turn it on yet.
Attachment #8888874 - Flags: review?(ethlin)
Comment on attachment 8888872 [details]
Bug 1383204 - Create webrender commands for the nsDisplayRemote display item.

https://reviewboard.mozilla.org/r/159892/#review165460

Great!
Attachment #8888872 - Flags: review?(ethlin) → review+
Comment on attachment 8888874 [details] [diff] [review]
Part 4 (optional) - Enable layers-free for chrome

Review of attachment 8888874 [details] [diff] [review]:
-----------------------------------------------------------------

I think it would be nice to know earlier if there is any issue with chrome.
Attachment #8888874 - Flags: review?(ethlin) → review+
Comment on attachment 8888870 [details]
Bug 1383204 - Remove unused function parameter.

https://reviewboard.mozilla.org/r/159888/#review165960
Attachment #8888870 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8888871 [details]
Bug 1383204 - Change helper function's return type to be more strongly typed.

https://reviewboard.mozilla.org/r/159890/#review165962
Attachment #8888871 - Flags: review?(matt.woodrow) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a989b3f4c690
Remove unused function parameter. r=mattwoodrow
https://hg.mozilla.org/integration/mozilla-inbound/rev/810678e8a29e
Change helper function's return type to be more strongly typed. r=mattwoodrow
https://hg.mozilla.org/integration/mozilla-inbound/rev/43aa857808d6
Create webrender commands for the nsDisplayRemote display item. r=ethlin
https://hg.mozilla.org/integration/mozilla-inbound/rev/961e6b6a79a2
Allow layers-free webrender mode in chrome prescontexts. r=ethlin
You need to log in before you can comment on or make changes to this bug.