1383207 - "select-all" (cmd-a) on the clear cookies list of cookies doesn't work

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Mark Mayo [:mmayo]]

STR:

1) Open preferences
2) Security and Privacy pane
3) click "clear individual cookies"
4) search for a domain with multiple cookies
5) select a single cookie from the list, and hit cmd-a
6) expected: entire list of cookies is selected.  actual: focus of select-all appears to be a the left column of text below the list (ie. individual cookie details)

56/Nightly, Build ID 20170721100207

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1383207 - Using the keyboard shortcut to select-all in the Cookies dialog should select all the visible cookies.

Review commit: https://reviewboard.mozilla.org/r/192614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192614/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8921589 [details]
Bug 1383207 - Using the keyboard shortcut to select-all in the Cookies dialog should select all the visible cookies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192614/diff/1-2/

Comment 3

[Evan Tseng [:evanxd]]

Comment on attachment 8921589 [details]
Bug 1383207 - Using the keyboard shortcut to select-all in the Cookies dialog should select all the visible cookies.

https://reviewboard.mozilla.org/r/192614/#review197976

::: browser/components/preferences/cookies.js:737
(Diff revision 2)
>      if (aEvent.keyCode == KeyEvent.DOM_VK_DELETE ||
>          (AppConstants.platform == "macosx" &&
>          aEvent.keyCode == KeyEvent.DOM_VK_BACK_SPACE)) {
>        this.deleteCookie();
>        aEvent.preventDefault();
> +    } else if (aEvent.ctrlKey &&

Hi Jared,

Do you think that we need to do OS platform dection here since generally the select all shortcut would be "ctrl (ctrlKey) + a" on Windows and Linux and "cmd (metaKey) + a" on macOS?

If we would like to do "ctrl + a" for all platforms, let's do it.

Comment 4

[Evan Tseng [:evanxd]]

Looks good to me if we would like to have the "ctrl + a" shortcut for all platforms (Windows, Linux, and macOS).

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8921589 [details]
Bug 1383207 - Using the keyboard shortcut to select-all in the Cookies dialog should select all the visible cookies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192614/diff/2-3/

Comment 6

[Evan Tseng [:evanxd]]

Comment on attachment 8921589 [details]
Bug 1383207 - Using the keyboard shortcut to select-all in the Cookies dialog should select all the visible cookies.

Looks good to me. Thank you.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d687c422bd8f
Using the keyboard shortcut to select-all in the Cookies dialog should select all the visible cookies. r=evanxd

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d687c422bd8f

Comment 9

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 56.0a1 (2017-07-21) on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20171204150510
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0