Closed Bug 1383207 Opened 4 years ago Closed 4 years ago

"select-all" (cmd-a) on the clear cookies list of cookies doesn't work

Categories

(Firefox :: Preferences, defect, P3)

56 Branch
x86_64
macOS
defect

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: mmayo, Assigned: jaws)

Details

Attachments

(1 file)

STR:

1) Open preferences
2) Security and Privacy pane
3) click "clear individual cookies"
4) search for a domain with multiple cookies
5) select a single cookie from the list, and hit cmd-a
6) expected: entire list of cookies is selected.  actual: focus of select-all appears to be a the left column of text below the list (ie. individual cookie details)

56/Nightly, Build ID 20170721100207
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Priority: -- → P3
Assignee: prathikshaprasadsuman → jaws
Comment on attachment 8921589 [details]
Bug 1383207 - Using the keyboard shortcut to select-all in the Cookies dialog should select all the visible cookies.

https://reviewboard.mozilla.org/r/192614/#review197976

::: browser/components/preferences/cookies.js:737
(Diff revision 2)
>      if (aEvent.keyCode == KeyEvent.DOM_VK_DELETE ||
>          (AppConstants.platform == "macosx" &&
>          aEvent.keyCode == KeyEvent.DOM_VK_BACK_SPACE)) {
>        this.deleteCookie();
>        aEvent.preventDefault();
> +    } else if (aEvent.ctrlKey &&

Hi Jared,

Do you think that we need to do OS platform dection here since generally the select all shortcut would be "ctrl (ctrlKey) + a" on Windows and Linux and "cmd (metaKey) + a" on macOS?

If we would like to do "ctrl + a" for all platforms, let's do it.
Attachment #8921589 - Flags: review?(evan) → review+
Looks good to me if we would like to have the "ctrl + a" shortcut for all platforms (Windows, Linux, and macOS).
Attachment #8921589 - Flags: review+ → review?(evan)
Comment on attachment 8921589 [details]
Bug 1383207 - Using the keyboard shortcut to select-all in the Cookies dialog should select all the visible cookies.

Looks good to me. Thank you.
Attachment #8921589 - Flags: review?(evan) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d687c422bd8f
Using the keyboard shortcut to select-all in the Cookies dialog should select all the visible cookies. r=evanxd
https://hg.mozilla.org/mozilla-central/rev/d687c422bd8f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
I have reproduced this bug with Nightly 56.0a1 (2017-07-21) on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20171204150510
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
QA Whiteboard: [bugday-20171213]
You need to log in before you can comment on or make changes to this bug.