1383208 - Console logging from a frame script breaks for some reason

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[:Gijs (he/him)]

STR:

1. open firefox with e10s turned on
2. enable and open browser console.
3. run:

gBrowser.selectedBrowser.messageManager.loadFrameScript("data:application/javascript,console.log(this.foo)", false);

ER:

logs whatever foo is, or maybe undefined, or something.

AR:

TypeError: consoleMsg.functionName is null
ContentProcessSingleton.js:62:9

from: 

https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/toolkit/components/processsingleton/ContentProcessSingleton.js#62-63

Comment 1

[Brian Grinstead [:bgrins]]

Huh, I guess we need to null check on the functionName before calling substring. I guess it makes sense that in this script the message doesn't have a functionName

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1383208 - Allow for null functionName in console messages;

Review commit: https://reviewboard.mozilla.org/r/161712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161712/

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8890569 [details]
Bug 1383208 - Allow for null functionName in console messages;

https://reviewboard.mozilla.org/r/161712/#review167198

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bb99bce4b89
Allow for null functionName in console messages;r=baku

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1bb99bce4b89

Comment 6

[Saheda Reza [:Antora]]

I have reproduced this bug on Nightly according to (2017-07-21)

Fixing bug is verified on Latest Beta--
Build ID    : 20170808170225
User Agent  :Mozilla/5.0 (Windows NT 6.1; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

Tested OS-- Windows7 64bit