1383272 - Fix RTP parsing error for RtpStreamId

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P1)

Description

[Michael Froman [:mjf]]

At the last minute, responding to a review request, I added a length check in the RtpStreamId parsing code.  I guess the webrtc.org gtests don't run on try because this failed here when I ran the tests on my linux box.  Easy fix, change "<=" to ">".  grr.  Fix on the way.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1383272 - fixing incorrect comparison in RtpStreamId::Parse(...)

When adding the length check for parsing RtpStreamId, I incorrectly used
the '<=' operator instead of the '>' operator.

Review commit: https://reviewboard.mozilla.org/r/159942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159942/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8888917 [details]
Bug 1383272 - fixing incorrect comparison in RtpStreamId::Parse(...)

https://reviewboard.mozilla.org/r/159942/#review165318

I wonder, how did this ever work?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b8225dac553
fixing incorrect comparison in RtpStreamId::Parse(...) r=bwc

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5b8225dac553