Closed
Bug 1383303
Opened 7 years ago
Closed 7 years ago
Support void returns in VMFunction
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
I've never looked at this code before, but AFAICT the only place that the return type is used is in JitRuntime::generateVMWrapper. I assume that we can just implement it by... not doing anything.
Assignee | ||
Comment 1•7 years ago
|
||
Is this really that simple? Anyways, L64 debug try is green... https://treeherder.mozilla.org/#/jobs?repo=try&revision=34c344c66b558522fa02fcb6daaf25bbfd650cb0&filter-tier=1
Assignee | ||
Comment 2•7 years ago
|
||
Oh, right, that was just to make sure it built on a variety of platforms. I need to do a real single platform push, too.
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6353e99f2135dde54f4c0074a510aea299e1a7fa&selectedJob=116542874
Assignee | ||
Comment 4•7 years ago
|
||
I don't really know what I'm doing here, so review carefully. ;)
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8889592 [details] Bug 1383303 - Support void returns from VM functions. https://reviewboard.mozilla.org/r/160618/#review166140 Looks good to me, thanks!
Attachment #8889592 -
Flags: review?(jdemooij) → review+
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e8deb6eb5ce Support void returns from VM functions. r=jandem
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3e8deb6eb5ce
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•