Closed Bug 1383303 Opened 7 years ago Closed 7 years ago

Support void returns in VMFunction

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

I've never looked at this code before, but AFAICT the only place that the return type is used is in JitRuntime::generateVMWrapper. I assume that we can just implement it by... not doing anything.
Blocks: 1383174
Oh, right, that was just to make sure it built on a variety of platforms. I need to do a real single platform push, too.
I don't really know what I'm doing here, so review carefully. ;)
Comment on attachment 8889592 [details]
Bug 1383303 - Support void returns from VM functions.

https://reviewboard.mozilla.org/r/160618/#review166140

Looks good to me, thanks!
Attachment #8889592 - Flags: review?(jdemooij) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e8deb6eb5ce
Support void returns from VM functions. r=jandem
https://hg.mozilla.org/mozilla-central/rev/3e8deb6eb5ce
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.