Closed Bug 1383326 Opened 2 years ago Closed 2 years ago

Silence AL warnings in the D3D11 debug layer

Categories

(Core :: Graphics: Layers, enhancement)

40 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1380142 added support for the D3D11 debug layer. AL spams the error log with a single warning that some constant buffers are smaller than the shader size expects. We do this on purpose and it's safe, the shader never reads beyond the bound buffer size. So we should just silence the warning.
Attached patch bug1383326.patch (obsolete) — Splinter Review
Attachment #8888986 - Flags: review?(bas)
Attached patch v2Splinter Review
Another fix. AL also triggers an error about OMSetRenderTarget while the RT is still bound as a pixel shader input. Technically it's harmless, we can either clear the binding or silence the warning. This clears the binding.
Attachment #8888986 - Attachment is obsolete: true
Attachment #8888986 - Flags: review?(bas)
Attachment #8889132 - Flags: review?(bas)
Attachment #8889132 - Flags: review?(bas) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5cee2b7e3a4
Silence spurious Advanced Layers warnings in the D3D11 debug layer. (bug 1383326, r=bas)
https://hg.mozilla.org/mozilla-central/rev/d5cee2b7e3a4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.