1383330 - Use current thread instead of main thread for ContentChild recursion check

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

A lot of the earlier Quantum DOM work had the goal of replacing usage of nsIThread with nsIEventTarget. That's because it's a bit difficult to reason about which thread you're getting when there are multiple "main" threads. However, there are a couple places where we actually need the nsThread. Checking the recursion count is one of those places, since there will be be different recursion counts for each cooperative thread.

This patch replaces some code that fetches the recursion count from NS_GetMainThread. The new code gets the recursion count from whichever thread is the current thread.

Comment 1

[Eric Rahm [:erahm]]

Comment on attachment 8888992 [details] [diff] [review]
patch

Review of attachment 8888992 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks for the thorough comment.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/74b6145a2873
Use current thread rather than main thread for ContentChild recursion check (r=erahm)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/74b6145a2873