Closed Bug 1383432 Opened 7 years ago Closed 6 years ago

-fno-lto workarounds aren't applied when building with -flto=n or -flto=thin: NSModules are not ordered appropriately

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1433383

People

(Reporter: jbeich, Unassigned)

Details

$ c++ -v
FreeBSD clang version 5.0.0 (trunk 308421) (based on LLVM 5.0.0svn)
Target: x86_64-unknown-freebsd12.0
Thread model: posix
InstalledDir: /usr/bin

$ echo 'int main() {}' | c++ -Wl,-v -xc++ - -o /dev/null
LLD 5.0.0 (FreeBSD 308421) (compatible with GNU linkers)

$ python2.7
>>> '-flto' in ['-ffoo', '-flto=thin', '-fbar']
False
>>> any(['-flto' in s for s in ['-ffoo', '-flto=thin', '-fbar']])
True

$ echo 'export CFLAGS="$CFLAGS -flto=thin"' >>.mozconfig
$ echo 'export CXXFLAGS="$CXXFLAGS -flto=thin"' >>.mozconfig
$ echo 'export LDFLAGS="$LDFLAGS -flto=thin -fuse-ld=lld"' >>.mozconfig

$ ./mach build
[...]
14:17.95 libxul_s.a.desc
14:17.95 libxul.so
18:24.23 NSModules are not ordered appropriately
18:24.23 gmake[5]: *** [config/rules.mk:720: libxul.so] Error 1
18:24.24 gmake[5]: *** Deleting file 'libxul.so'
[...]
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.