Closed Bug 1383513 Opened 7 years ago Closed 7 years ago

Do not set max-height for the comment field without autosize.

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1389111

People

(Reporter: arai, Unassigned)

References

Details

Currently the max-height is set regardless of whether autosize is enabled or not, but max-height is not necessary for manual-resize mode.
https://github.com/wlach/bmo/blob/f6cb178bc8ec2614c620ad773f2e29ed944c1c77/extensions/BugModal/web/bug_modal.css#L717
>  max-height: 400px;

instead, the style should be applied when applying autosize

https://github.com/mozilla-bteam/bmo/blob/a01545cbec992560a5bfe402cf395aabb97d5cfd/extensions/BugModal/web/bug_modal.js#L879
>  autosize($('#comment'));
(In reply to Tooru Fujisawa [:arai] from comment #0)
> instead, the style should be applied when applying autosize
> 
> https://github.com/mozilla-bteam/bmo/blob/
> a01545cbec992560a5bfe402cf395aabb97d5cfd/extensions/BugModal/web/bug_modal.
> js#L879
> >  autosize($('#comment'));

I am not sure if this is the best solution technically but the diagnosis is correct.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Component: User Interface: Modal → User Interface
You need to log in before you can comment on or make changes to this bug.