Closed
Bug 1383533
Opened 7 years ago
Closed 7 years ago
tabmail.css cleanup
Categories
(Thunderbird :: Theme, enhancement)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 56.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
13.83 KB,
patch
|
jorgk-bmo
:
review+
aceman
:
review+
|
Details | Diff | Splinter Review |
tabmail.css has some rules we can move to shared/tabmail.css. There are also rules we should remove to make the different platforms use the same rules where possible.
Assignee | ||
Comment 1•7 years ago
|
||
Moved the .tabmail-arrowscrollbox, .tab-throbber, .alltabs-item, .tabmail-tab[type="glodaSearch"] and .tabmail-tab:not([selected]):not(:-moz-lwtheme) rules to shared. The glodaSearch tab icon behaves now like the options tab icon and uses the same colors as the text. The rules I removed from the Linux and macOS files are to let the tab text inherit the toolbar colors like we already do on Windows.
Comment 2•7 years ago
|
||
Comment on attachment 8889165 [details] [diff] [review] tabmailCleanup.patch This works fine on Windows. Maybe Aceman can quickly check Linux.
Attachment #8889165 -
Flags: review?(jorgk)
Attachment #8889165 -
Flags: review?(acelists)
Attachment #8889165 -
Flags: review+
Comment on attachment 8889165 [details] [diff] [review] tabmailCleanup.patch Review of attachment 8889165 [details] [diff] [review]: ----------------------------------------------------------------- I also didn't find any visible problems on Linux. The icon of the gloda tab now takes the color of the text (tab title), which is taken from the theme.
Attachment #8889165 -
Flags: review?(acelists) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Thanks. Jörg, can you on check-in add aceman as reviewer?
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/97fc9b087a3a tabmail.css cleanup (move rules to shared/tabmail.css and delete unneeded rules). r=jorgk,aceman
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 56.0
You need to log in
before you can comment on or make changes to this bug.
Description
•