Closed Bug 1383560 Opened 7 years ago Closed 3 years ago

Move add-on install to the "doorhanger" install flow

Categories

(Thunderbird :: Add-Ons: General, enhancement)

45 Branch
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: rkent, Unassigned)

References

Details

See this comment in m.d.platform by Andrew Swan in the topic 'removing "the old way" of signing addons':

"While we're on the topic, Thunderbird and Seamonkey should look at moving
over to the doorhanger addon install flow that Firefox uses -- that xul
dialog and everything that supports it are unused in Firefox and its days
are numbered."
More information from Andrew Swan:

The dialog I mentioned is:
https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/xpinstallConfirm.xul

The listbox in that dialog holds instances of:
https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/xpinstallItem.xml

The label in those items with the class "xpinstallItemSigned" ends up
holding either certificate details or some default message like "Author not
verified"

=== And more ===

these applications [TB/SM] should create listeners for
the various events that are generated during the install process.  Whether
you try to adapt the Firefox doorhangers somehow or keep some version of
the current dialog (but apropos the original message in this thread, even
that is likely to change) doesn't matter to me, but the existing code that
displays a modal xul dialog from the guts of the addons manager isn't long
for this world...
Summary: Move addon install to the "doorhanger" install flow → Move add-on install to the "doorhanger" install flow
See Also: → 1473178
Component: General → Add-Ons: General

I checked our current source, and we currently do not use any of that (anymore). Close?

Flags: needinfo?(geoff)

We've already done this, effectively.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(geoff)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.