Using bugfiler to file devtools debugger bugs with comments fails with: Bug Filer API returned status 500 (Internal Server Error)

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: aryx, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

I tried to file a bug for https://treeherder.mozilla.org/logviewer.html#?job_id=116736317&repo=autoland in Firefox :: Developer Tools: Debugger

Using the comments field, the bug filing failed with:

>Bug Filer API returned status 500 (Internal Server Error) 

This happened several times today for debugger bugs.

Comment used:

09:05:05     INFO - Waiting on sources: simple1, simple2
09:05:05     INFO - TEST-PASS | devtools/client/debugger/new/test/mochitest/browser_dbg-tabs.js | undefined assertion name - 
09:05:05     INFO - Leaving test bound 
09:05:05     INFO - Console message: [JavaScript Error: "TypeError: aBrowser is null" {file: "resource:///modules/ZoomUI.jsm" line: 62}]
09:05:05     INFO - Removing tab.
09:05:05     INFO - Waiting for event: 'TabClose' on [object XULElement].
09:05:05     INFO - Got event: 'TabClose' on [object XULElement].
09:05:05     INFO - Tab removed and finished closing
09:05:05     INFO - Console message: [JavaScript Error: "TypeError: aBrowser is null" {file: "resource:///modules/ZoomUI.jsm" line: 62}]
09:05:05     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “http://example.com/browser/devtools/client/debugger/new/test/mochitest/examples/simple1.js”." {file: "http://example.com/browser/devtools/client/debugger/new/test/mochitest/examples/doc-scripts.html" line: 11}]
09:05:05     INFO - Removing tab.
09:05:05     INFO - Waiting for event: 'TabClose' on [object XULElement].
09:05:05     INFO - Got event: 'TabClose' on [object XULElement].
09:05:05     INFO - Tab removed and finished closing
09:05:05     INFO - Buffered messages finished
09:05:05     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/new/test/mochitest/browser_dbg-tabs.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
(Assignee)

Comment 1

9 months ago
How consistently is this failing?
Flags: needinfo?(aryx.bugmail)
3 of the last 3 attempts yesterday to file something with a comment against Firefox :: Developer Tools: Debugger. Removing the comment fixes it. Haven't observed the behavior when I filed bugs with comments against other components.
Flags: needinfo?(aryx.bugmail)

Comment 3

9 months ago
From New Relic:

treeherder.webapp.api.bugzilla:BugzillaViewSet.create_bug
exceptions:UnicodeEncodeError: 'ascii' codec can't encode character u'\u201c' in position 1053: ordinal not in range(128)

https://rpm.newrelic.com/accounts/677903/applications/14179757/filterable_errors#/show/1503f765-6ff9-11e7-931c-0242ac110012_0_4858/stack_trace?top_facet=transactionUiName&primary_facet=error.class&barchart=barchart&_k=g38m9t
(Assignee)

Comment 4

9 months ago
That's the funky quotes in:
“http://example.com/browser/devtools/client/debugger/new/test/mochitest/examples/simple1.js”

From the newrelic error, it's failing at https://github.com/mozilla/treeherder/blob/master/treeherder/webapp/api/bugzilla.py#L32


So what would be the best fix? Can we clean up the comments to swap out those quotes for ascii ones, or is there something to do to not let it use the 'ascii' codec?
Flags: needinfo?(emorley)

Comment 5

9 months ago
Created attachment 8889588 [details] [review]
[treeherder] KWierso:uniiiiiicode > mozilla:master
(Assignee)

Updated

9 months ago
Assignee: nobody → wkocher
(Assignee)

Comment 7

9 months ago
Comment on attachment 8889588 [details] [review]
[treeherder] KWierso:uniiiiiicode > mozilla:master

This seems to work in the new test I added, and none of the other tests broke when I changed them to use utf-8 strings.

Descriptions and Summaries should now accept unicode without breaking.
Attachment #8889588 - Flags: review?(emorley)

Comment 8

9 months ago
Comment on attachment 8889588 [details] [review]
[treeherder] KWierso:uniiiiiicode > mozilla:master

Cameron, I don't suppose you could take this one?
Attachment #8889588 - Flags: review?(emorley) → review?(cdawson)
Comment on attachment 8889588 [details] [review]
[treeherder] KWierso:uniiiiiicode > mozilla:master

This looks good to me.  I had to do something very similar with Push ingestion recently.  :)
Attachment #8889588 - Flags: review?(cdawson) → review+

Comment 10

9 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/98622164f7b24a6766993aa97e5f91ff6d2aec27
Bug 1383581 - (Bug filer) Let the bug filer accept unicode (#2652) r=camd
(Assignee)

Updated

9 months ago
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.