1383608 - ignoring unknown option '-mpclmul' and '-maes' when building on MSVC

Status: NEW

(NSS :: Libraries, defect, P3)

Description

[Makoto Kato [:m_kato]]

When building NSS on m-c for MSVC, a lot of warning is outputted.

 3:22.55 cl : Command line warning D9002 : ignoring unknown option '-mpclmul'
 3:22.55 cl : Command line warning D9002 : ignoring unknown option '-maes'

This is added by bug 868948.  This is gcc build flags and it is unnecessary on MSVC build

Comment 1

[Franziskus Kiefer [:franziskus]]

They are necessary for clang-cl builds. Since MSVC happily ignores them I didn't see a reason to remove them there. If the warnings are too much we might be able to do something about it.

Comment 2

[Mark Straver]

IMO, feeding known-incorrect compiler flags to a compiler isn't something you should be doing. If MSVC stops "happily ignoring them" then you're in trouble.
The warnings are serious enough to draw attention, at the very least, or I wouldn't be here after updating my lib ;)