Closed Bug 1383657 Opened 7 years ago Closed 7 years ago
Incorrect declaration in the switch/case (break before the expression)
59 bytes, text/x-review-board-request
https://hg.mozilla.org/mozilla-central/file/tip/docshell/base/nsDocShell.cpp#l1150 this is probably not what we want to do
Thanks, yes, this needs a fix!
Comment on attachment 8889339 [details] Bug 1383657 - Fix the incorrectly placed 'break;' in the switch/case declaration =mayhemer https://reviewboard.mozilla.org/r/160418/#review165682
Attachment #8889339 - Flags: review+
(using autoland in mozreview)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/54deee11a7c5 Fix the incorrectly placed 'break;' in the switch/case declaration r=mayhemer=mayhemer
This bug would also have been caught by clang's -Wunreachable-code-break warning ... if it had been enabled. :) I have local patches to enable these warnings. I should post them for review soon.
yeah! we should do that fyi, gcc 7.1 has -Wswitch-unreachable which found bug 1383007
You need to log in before you can comment on or make changes to this bug.