Closed
Bug 1383657
Opened 7 years ago
Closed 7 years ago
Incorrect declaration in the switch/case (break before the expression)
Categories
(Core :: DOM: Navigation, enhancement)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1415663])
Attachments
(1 file)
https://hg.mozilla.org/mozilla-central/file/tip/docshell/base/nsDocShell.cpp#l1150 this is probably not what we want to do
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
Thanks, yes, this needs a fix!
|
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8889339 [details] Bug 1383657 - Fix the incorrectly placed 'break;' in the switch/case declaration =mayhemer https://reviewboard.mozilla.org/r/160418/#review165682
Attachment #8889339 -
Flags: review+
|
|
||
Updated•7 years ago
|
Keywords: checkin-needed
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•7 years ago
|
||
(using autoland in mozreview)
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/54deee11a7c5 Fix the incorrectly placed 'break;' in the switch/case declaration r=mayhemer=mayhemer
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/54deee11a7c5
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Comment 7•7 years ago
|
||
This bug would also have been caught by clang's -Wunreachable-code-break warning ... if it had been enabled. :) I have local patches to enable these warnings. I should post them for review soon.
|
|
Assignee | |
Comment 8•7 years ago
|
||
yeah! we should do that fyi, gcc 7.1 has -Wswitch-unreachable which found bug 1383007
You need to log in
before you can comment on or make changes to this bug.
Description
•