1383691 - Performance user/resource entries should be reported in about:memory

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: measure.patch

This is the separate bug for the memory report for the Performance API.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8889434 [details] [diff] [review]
measure.patch

>+  nsGlobalWindow* inner = aWindow->IsOuterWindow() ? aWindow->GetCurrentInnerWindowInternal()
>+                                                   : aWindow;

I'd think we only want to report the performance stuff for an inner window, since that's what it's scoped to.

>+  RefPtr<Performance> performance = inner->GetPerformance();

GetPerformance() creates the object if it's not there.  Might be a good idea to add an accessor (e.g. GetExistingPerformanceObject() or something) that just returns mPerformance, with comments pointing out that it's meant for use from here only.

Or better yet, put this code inside nsGlobalWindow::AddSizeOfIncludingThis so that we don't have to create an accessor at all.  Then this will also be able to play nicely with whatever summary stats aWindowTotalSizes is keeping track of.

The rest looks good, but please address the above.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: measure.patch

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8889740 [details] [diff] [review]
measure.patch

r=me

Comment 5

[Guilherme Lima]

The patch landed with the wrong number (1382768)
https://hg.mozilla.org/integration/mozilla-inbound/rev/b17eb8514a10
https://hg.mozilla.org/mozilla-central/rev/b17eb8514a10