Closed
Bug 1383701
Opened 7 years ago
Closed 7 years ago
Perma failure when 56 merges to beta in browser_all_files_referenced.js | unused whitelist entry: chrome://payments/content/paymentRequest.xhtml -
Categories
(Firefox :: WebPayments UI, defect)
Firefox
WebPayments UI
Tracking
()
RESOLVED
FIXED
Firefox 56
People
(Reporter: cbook, Assigned: jonathanGB)
References
()
Details
Attachments
(1 file)
[Tracking Requested - why for this release]: uplift simulations show a new perma failure when Gecko 56 moves to beta like 135 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unused whitelist entry: chrome://payments/content/paymentRequest.xhtml - https://treeherder.mozilla.org/logviewer.html#?job_id=116862096&repo=try might be caused by bug 1381141
Reporter | ||
Comment 1•7 years ago
|
||
Jonathan: could you take a look , thanks!
Flags: needinfo?(jguillotteblouin)
Comment 2•7 years ago
|
||
I guess we need to do like MOZ_PHOTON THEME and put the whitelist entry in an if which matches the moz.build and packaging #if: https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/browser/base/content/test/static/browser_all_files_referenced.js#178-179
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8889994 [details] Bug 1383701 - whitelist paymentRequest.xhtml only when building paymentRequest. https://reviewboard.mozilla.org/r/161056/#review166462
Attachment #8889994 -
Flags: review?(MattN+bmo) → review+
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/57d0b46a7d4d whitelist paymentRequest.xhtml only when building paymentRequest. r=MattN
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(jguillotteblouin)
Reporter | ||
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/57d0b46a7d4d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Assignee: nobody → jguillotteblouin
Assignee | ||
Comment 8•7 years ago
|
||
:RyanVM, the patch was submitted on July 25th, while the 7 failures date from July 24th. Most probably a false alert.
Comment 9•7 years ago
|
||
...all I did was fill in the assignee field?
Assignee | ||
Comment 10•7 years ago
|
||
:RyanVM, my bad, I thought you were assigning me to it following the message from "OrangeFactor Robot" :P Sorry!
Updated•6 years ago
|
Product: Toolkit → Firefox
Target Milestone: mozilla56 → Firefox 56
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•