Perma failure when 56 merges to beta in browser_all_files_referenced.js | unused whitelist entry: chrome://payments/content/paymentRequest.xhtml -

RESOLVED FIXED in Firefox 56

Status

()

Toolkit
WebPayments UI
--
blocker
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: Tomcat, Assigned: jonathanGB)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56? fixed)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
[Tracking Requested - why for this release]:

uplift simulations show a new perma failure when Gecko 56 moves to beta like

 135 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unused whitelist entry: chrome://payments/content/paymentRequest.xhtml - 

https://treeherder.mozilla.org/logviewer.html#?job_id=116862096&repo=try

might be caused by bug 1381141
(Reporter)

Comment 1

4 months ago
Jonathan: could you take a look , thanks!
Flags: needinfo?(jguillotteblouin)
I guess we need to do like MOZ_PHOTON THEME and put the whitelist entry in an if which matches the moz.build and packaging #if:
https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/browser/base/content/test/static/browser_all_files_referenced.js#178-179
Comment hidden (mozreview-request)
Comment on attachment 8889994 [details]
Bug 1383701 - whitelist paymentRequest.xhtml only when building paymentRequest.

https://reviewboard.mozilla.org/r/161056/#review166462
Attachment #8889994 - Flags: review?(MattN+bmo) → review+

Comment 5

4 months ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/57d0b46a7d4d
whitelist paymentRequest.xhtml only when building paymentRequest. r=MattN
(Assignee)

Updated

4 months ago
Flags: needinfo?(jguillotteblouin)
(Reporter)

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/57d0b46a7d4d
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Comment 7

4 months ago
7 failures in 1008 pushes (0.007 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* try: 7

Platform breakdown:
* windows7-32-vm: 3
* windows7-32: 2
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1383701&startday=2017-07-24&endday=2017-07-30&tree=all
Assignee: nobody → jguillotteblouin
:RyanVM, the patch was submitted on July 25th, while the 7 failures date from July 24th. Most probably a false alert.
...all I did was fill in the assignee field?
:RyanVM, my bad, I thought you were assigning me to it following the message from "OrangeFactor Robot" :P

Sorry!
You need to log in before you can comment on or make changes to this bug.