Perma failure when 56 merges to beta in browser_notification_open_settings.js | Test timed out -

RESOLVED FIXED in Firefox 56

Status

()

defect
--
blocker
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cbook, Assigned: jaws)

Tracking

unspecified
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56+ fixed)

Details

()

Attachments

(1 attachment)

[Tracking Requested - why for this release]:

found via uplift simulations: -> https://treeherder.mozilla.org/logviewer.html#?job_id=116862210&repo=try

 TEST-UNEXPECTED-FAIL | browser/base/content/test/alerts/browser_notification_open_settings.js | Test timed out - 

this is a very frequent failure in the uplift simulations so need to be fixed before 56 merges to beta next week.

Maybe from Bug 1381944 ?
Mike, Jared: could you take a look ? Thanks!
Flags: needinfo?(mconley)
Flags: needinfo?(jaws)
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(mconley)
Flags: needinfo?(jaws)
Track 56+ as this may affect 56 merging to beta.
Comment on attachment 8889664 [details]
Bug 1383709 - Don't wait for the sync-pane-loaded notification in old prefs since it won't be fired when only viewing the Content pane.

https://reviewboard.mozilla.org/r/160728/#review166780

::: browser/base/content/test/alerts/browser_notification_open_settings.js:20
(Diff revision 1)
> -    // Ensure preferences is loaded before removing the tab.
> -    let syncPaneLoadedPromise = TestUtils.topicObserved("sync-pane-loaded", () => true);
> +    // Ensure preferences is loaded before removing the tab. In the "new prefs", all categories
> +    // get initialized on page load since we need to be able to search them. Sync is *very*
> +    // slow to load and therefore we need to wait for it to load when testing the "new prefs".
> +    // For "old prefs" we only load the actual visited categories so we don't have this problem,
> +    // as well, the "sync-pane-loaded" notification is not sent on "old prefs".
> +    let syncPaneLoadedPromise = useOldPrefs || TestUtils.topicObserved("sync-pane-loaded", () => true);

TIL you can `await` a non-Promise and it'll be automatically coerced into a resolved Promise. Neat!
Attachment #8889664 - Flags: review?(mconley) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35b75b53f9d3
Don't wait for the sync-pane-loaded notification in old prefs since it won't be fired when only viewing the Content pane. r=mconley
https://hg.mozilla.org/mozilla-central/rev/35b75b53f9d3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.