Closed Bug 1383714 Opened 2 years ago Closed 2 years ago

Update to cbindgen 0.1.19

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Testing the next WR update ran into some issues, see bug 1383041 comment 1 and the next few comments after that. Ryan patched cbindgen to deal with it, and we should update our generated FFI head and some nearby code to the new stuff from cbindgen 0.1.19. This will fix the issues on the next WR update.
Comment on attachment 8889417 [details]
Bug 1383714 - Update to cbindgen 0.1.19.

https://reviewboard.mozilla.org/r/160450/#review165706
Attachment #8889417 - Flags: review?(bugmail) → review+
Ryan, any objections to landing this patch? I kept you as the patch author and used myself as the reviewer, although you should take a look at the changes I made to rebase it to m-c tip (i.e. https://hg.mozilla.org/try/rev/7303b660598634328f2ac7ca52e84193d7eedc4c) and make sure it looks ok to you.
Flags: needinfo?(rhunt)
No objections, that looks good to me.
Flags: needinfo?(rhunt)
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/23cefa3181ce
Update to cbindgen 0.1.19. r=kats
https://hg.mozilla.org/mozilla-central/rev/23cefa3181ce
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.