Update to cbindgen 0.1.19

RESOLVED FIXED in Firefox 56

Status

()

Core
Graphics: WebRender
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: kats, Assigned: kats)

Tracking

Other Branch
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Testing the next WR update ran into some issues, see bug 1383041 comment 1 and the next few comments after that. Ryan patched cbindgen to deal with it, and we should update our generated FFI head and some nearby code to the new stuff from cbindgen 0.1.19. This will fix the issues on the next WR update.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

a year ago
mozreview-review
Comment on attachment 8889417 [details]
Bug 1383714 - Update to cbindgen 0.1.19.

https://reviewboard.mozilla.org/r/160450/#review165706
Attachment #8889417 - Flags: review?(bugmail) → review+
Ryan, any objections to landing this patch? I kept you as the patch author and used myself as the reviewer, although you should take a look at the changes I made to rebase it to m-c tip (i.e. https://hg.mozilla.org/try/rev/7303b660598634328f2ac7ca52e84193d7eedc4c) and make sure it looks ok to you.
Flags: needinfo?(rhunt)

Comment 4

a year ago
No objections, that looks good to me.
Flags: needinfo?(rhunt)

Comment 5

a year ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/23cefa3181ce
Update to cbindgen 0.1.19. r=kats

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/23cefa3181ce
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.