1383737 - Change talos quantum pageloader test names and job symbols

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Robert Wood [:rwood]]

As noted by :cpeterson, the talos quantum-pageload test names are quite long and aren't the best for when viewing data in perfherder. We should change the test names from quantum_pageload_* to tp6_*. Also change the corresponding job symbols, I would suggest:

q1 => tp6
q1s => tp6s

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

treeherder changes can be fixed with a treeherder change.

As for the long names, that needs to be fixed in talos, talos.json, and buildbot-configs.  I do wonder if we could find a way to do this with just a small talos change.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

while we are at the treeherder changes, lets account for tp6st (the new upcoming threads version)

Comment 3

[Robert Wood [:rwood]]

(In reply to Joel Maher ( :jmaher) (UTC-8) from comment #2)
> while we are at the treeherder changes, lets account for tp6st (the new
> upcoming threads version)

Ok, that can be added to the treeherder etl data along with these changes.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

I see tp6, tp6s on treeherder now, it appears we are running the right jobs symbols, there is the last step where we need to change the actual test names from quantum_pageload -> tp6.  Here is an example:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd3dca8301256e4368280d3e5d02c65bc5f30cca

:cpeterson, this will stop the existing tests and create new tests- is that ok with you?

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Joel Maher ( :jmaher) (UTC-9) from comment #4)
> :cpeterson, this will stop the existing tests and create new tests- is that
> ok with you?

Does stopping the existing tests and creating new tests mean we will lose the historical quantum_pageload measurements in Perfherder? That is fine. rwood recently changed tp6 to measure "time to non-blank paint" (bug 1363845) instead of onload time, so the historical quantum_pageload measurements are no longer comparable.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

the old data  will be there, it just won't be a continuous line, you will have to load two data sets to see the historical + new data.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: turn on tp6 stylo threads, rename test names to shorter tp6

:ahal, this is mostly taskcluster and simple talos test name changes.  :rwood is out on holiday and :armenzg is out for the afternoon- could you look over this.

here is a try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd3dca8301256e4368280d3e5d02c65bc5f30cca

Comment 8

[Andrew Halberstadt [:ahal]]

Comment on attachment 8893487 [details] [diff] [review]
turn on tp6 stylo threads, rename test names to shorter tp6

Review of attachment 8893487 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/638bd646ed37
Change talos quantum pageloader test names and job symbols. r=ahal

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/638bd646ed37