Closed
Bug 1383748
Opened 7 years ago
Closed 7 years ago
https proxy does not work properly
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | - | fixed |
firefox56 | --- | fixed |
People
(Reporter: Off.Just.Off, Assigned: wcpan)
References
Details
(Keywords: regression, Whiteboard: [necko-active])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
mcmanus
:
review+
jcristau
:
approval-mozilla-beta+
|
Details |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0 Build ID: 20170710123658 Steps to reproduce: Setup https proxy using nsIProtocolProxyService and try to use it. Here is the test add-on: https://github.com/JustOff/https-proxy-test Proxy used in this example is restricted by domain list, so we should go to test url, that is known as allowed to access through this proxy: http://ipv4.internet.yandex.net/internet/api/v0/ip Actual results: Firefox 55+ can't establish connection through the proxy. Expected results: Browser should receive the answer from the test server through the proxy.
Mozregression pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3fbab2a560cefb71de5a1f02016a6dfe26c9dfe8&tochange=be92b87fefed11a26d06c30b9f9c91c913ae46af
Comment 2•7 years ago
|
||
[Tracking Requested - why for this release]: https proxy does not work properly @:wcpan, It seems to trigger this problem by your patch. Could you look this?
Blocks: 1310127
Has Regression Range: --- → yes
status-firefox55:
--- → affected
tracking-firefox55:
--- → ?
Flags: needinfo?(wpan)
Keywords: regression
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → wpan
Flags: needinfo?(wpan)
Thank you for digging into it, Wei-Cheng Pan! I hope there is still a chance the fix will be included into upcoming 55 release.
Updated•7 years ago
|
Whiteboard: [necko-active]
Updated•7 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8890816 [details] Bug 1383748 - Fix SPDY while using proxy. https://reviewboard.mozilla.org/r/162034/#review167482 as its a regression, please fill out the uplift request
Attachment #8890816 -
Flags: review?(mcmanus) → review+
Pushed by wpan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/de8759dd2b22 Fix SPDY while using proxy. r=mcmanus
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/de8759dd2b22
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 8890816 [details] Bug 1383748 - Fix SPDY while using proxy. Approval Request Comment [Feature/Bug causing the regression]: bug 1310127 [User impact if declined]: HTTP Proxies might not work properly. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: This is a simple fix, does not affect other functions. [String changes made/needed]: None.
Attachment #8890816 -
Flags: approval-mozilla-beta?
Comment 9•7 years ago
|
||
Comment on attachment 8890816 [details] Bug 1383748 - Fix SPDY while using proxy. proxy/spdy fix for 55 rc1
Attachment #8890816 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/993bfbae557c
Updated•7 years ago
|
Updated•7 years ago
|
status-firefox54:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Reporter | ||
Comment 11•7 years ago
|
||
Many thanks to everyone involved in fixing this issue and especially for the well-timed uplifting!
You need to log in
before you can comment on or make changes to this bug.
Description
•