Closed Bug 1383748 Opened 3 years ago Closed 3 years ago
https proxy does not work properly
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0 Build ID: 20170710123658 Steps to reproduce: Setup https proxy using nsIProtocolProxyService and try to use it. Here is the test add-on: https://github.com/JustOff/https-proxy-test Proxy used in this example is restricted by domain list, so we should go to test url, that is known as allowed to access through this proxy: http://ipv4.internet.yandex.net/internet/api/v0/ip Actual results: Firefox 55+ can't establish connection through the proxy. Expected results: Browser should receive the answer from the test server through the proxy.
[Tracking Requested - why for this release]: https proxy does not work properly @:wcpan, It seems to trigger this problem by your patch. Could you look this?
3 years ago
Assignee: nobody → wpan
Thank you for digging into it, Wei-Cheng Pan! I hope there is still a chance the fix will be included into upcoming 55 release.
Comment on attachment 8890816 [details] Bug 1383748 - Fix SPDY while using proxy. https://reviewboard.mozilla.org/r/162034/#review167482 as its a regression, please fill out the uplift request
Attachment #8890816 - Flags: review?(mcmanus) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/de8759dd2b22 Fix SPDY while using proxy. r=mcmanus
Comment on attachment 8890816 [details] Bug 1383748 - Fix SPDY while using proxy. Approval Request Comment [Feature/Bug causing the regression]: bug 1310127 [User impact if declined]: HTTP Proxies might not work properly. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: This is a simple fix, does not affect other functions. [String changes made/needed]: None.
Attachment #8890816 - Flags: approval-mozilla-beta?
Comment on attachment 8890816 [details] Bug 1383748 - Fix SPDY while using proxy. proxy/spdy fix for 55 rc1
Attachment #8890816 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Many thanks to everyone involved in fixing this issue and especially for the well-timed uplifting!
You need to log in before you can comment on or make changes to this bug.