1383748 - https proxy does not work properly

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[JustOff]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170710123658

Steps to reproduce:

Setup https proxy using nsIProtocolProxyService and try to use it.

Here is the test add-on: https://github.com/JustOff/https-proxy-test

Proxy used in this example is restricted by domain list, so we should go to test url, that is known as allowed to access through this proxy: http://ipv4.internet.yandex.net/internet/api/v0/ip


Actual results:

Firefox 55+ can't establish connection through the proxy.


Expected results:

Browser should receive the answer from the test server through the proxy.

Comment 1

[JustOff]

Mozregression pushlog: 

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3fbab2a560cefb71de5a1f02016a6dfe26c9dfe8&tochange=be92b87fefed11a26d06c30b9f9c91c913ae46af

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]: https proxy does not work properly

@:wcpan,
It seems to trigger this problem by your patch.
Could you look this?

Comment 3

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Attachment: Bug 1383748 - Fix SPDY while using proxy.

The SPDY status variable was overwrited by other function. Giving it a new
meaningful name to prevent possible regression again.

Review commit: https://reviewboard.mozilla.org/r/162034/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162034/

Comment 4

[JustOff]

Thank you for digging into it, Wei-Cheng Pan!

I hope there is still a chance the fix will be included into upcoming 55 release.

Comment 5

[Patrick McManus [:mcmanus]]

Comment on attachment 8890816 [details]
Bug 1383748 - Fix SPDY while using proxy.

https://reviewboard.mozilla.org/r/162034/#review167482

as its a regression, please fill out the uplift request

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de8759dd2b22
Fix SPDY while using proxy. r=mcmanus

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/de8759dd2b22

Comment 8

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Comment on attachment 8890816 [details]
Bug 1383748 - Fix SPDY while using proxy.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1310127
[User impact if declined]: HTTP Proxies might not work properly.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: This is a simple fix, does not affect other functions.
[String changes made/needed]: None.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8890816 [details]
Bug 1383748 - Fix SPDY while using proxy.

proxy/spdy fix for 55 rc1

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/993bfbae557c

Comment 11

[JustOff]

Many thanks to everyone involved in fixing this issue and especially for the well-timed uplifting!