Closed
Bug 1383756
Opened 7 years ago
Closed 7 years ago
Avoid excessive AddRef()ing of atoms in nsNodeInfoManager::GetNodeInfo()
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
2.93 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
We make the NodeInfoInner members raw pointers, and AddRef/Release them manally in the constructor/destructor of NodeInfo, and in the cases where NodeInfoInner objects are created for hashtable lookups, no further refcounting is performed.
Attachment #8889464 -
Flags: review?(amarchesini)
Assignee | ||
Comment 2•7 years ago
|
||
Bobby, can you please review the servo side of these changes? https://github.com/servo/servo/pull/17842
Flags: needinfo?(bobbyholley)
Updated•7 years ago
|
Attachment #8889464 -
Flags: review?(amarchesini) → review+
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c1198677943c Avoid excessive AddRef()ing of atoms in nsNodeInfoManager::GetNodeInfo(); r=baku
Flags: needinfo?(bobbyholley)
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c1198677943c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•