1383803 - Update Debugger frontend (7/24/2017).

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

includes lots of polish and some fixes for breakpoints and the new Editor editor.state.editor functionality.

Comment 1

[Jason Laster [:jlast]]

Attachment: 7-24-1.patch

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ac219561bc4a4ccd92c5fb12dc92579b3c82e9c

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8889503 [details] [diff] [review]
7-24-1.patch

Review of attachment 8889503 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks. 
I only did very minimal testing, but looks like breakpoints no longer disappear, great!

::: devtools/client/sourceeditor/editor.js
@@ +462,5 @@
>    replaceDocument: function (doc) {
>      let cm = editors.get(this);
>      cm.swapDoc(doc);
> +    if (!Services.prefs.getBoolPref("devtools.debugger.new-debugger-frontend")) {
> +      this._updateLineNumberFormat();

(just as a sidenote, there is another call to updateLineNumberFormat in setText(), is this one fine for the new debugger?)

Comment 4

[Jason Laster [:jlast]]

Attachment: 7-24-2.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9721c2c4368
Update debugger frontend (v0.9.0). r=jdescottes

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a9721c2c4368