Closed
Bug 1383803
Opened 7 years ago
Closed 7 years ago
Update Debugger frontend (7/24/2017).
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file, 1 obsolete file)
31.29 KB,
patch
|
Details | Diff | Splinter Review |
includes lots of polish and some fixes for breakpoints and the new Editor editor.state.editor functionality.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8889503 -
Flags: review?(jdescottes)
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ac219561bc4a4ccd92c5fb12dc92579b3c82e9c
Updated•7 years ago
|
Assignee: nobody → jlaster
Status: NEW → ASSIGNED
Priority: -- → P3
Comment 3•7 years ago
|
||
Comment on attachment 8889503 [details] [diff] [review] 7-24-1.patch Review of attachment 8889503 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, thanks. I only did very minimal testing, but looks like breakpoints no longer disappear, great! ::: devtools/client/sourceeditor/editor.js @@ +462,5 @@ > replaceDocument: function (doc) { > let cm = editors.get(this); > cm.swapDoc(doc); > + if (!Services.prefs.getBoolPref("devtools.debugger.new-debugger-frontend")) { > + this._updateLineNumberFormat(); (just as a sidenote, there is another call to updateLineNumberFormat in setText(), is this one fine for the new debugger?)
Attachment #8889503 -
Flags: review?(jdescottes) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8889503 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9721c2c4368 Update debugger frontend (v0.9.0). r=jdescottes
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a9721c2c4368
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•